Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: Source/core/streams/ReadableStream.h

Issue 1004623007: Streams Implementation Update: async read (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@stream-reader-read
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/streams/ReadableStream.h
diff --git a/Source/core/streams/ReadableStream.h b/Source/core/streams/ReadableStream.h
index 1dea3cce09cc0c0ebbca965571755e7a8b5bf6a8..5d84fc999b97f44b798dd3dadca9de2669d52110 100644
--- a/Source/core/streams/ReadableStream.h
+++ b/Source/core/streams/ReadableStream.h
@@ -30,7 +30,6 @@ class ReadableStream : public GarbageCollectedFinalized<ReadableStream>, public
public:
enum State {
Readable,
- Waiting,
Closed,
Errored,
};
@@ -47,17 +46,12 @@ public:
State stateInternal() const { return m_state; }
DOMException* storedException() { return m_exception.get(); }
- // |stateString|, |read| and |ready| are affected by an exclusive lock. Use
- // |stateInternal|, |readInternal| and |readyInternal| if you want to avoid
- // that.
- String stateString() const;
- ScriptValue read(ScriptState*, ExceptionState&);
- ScriptPromise ready(ScriptState*);
+ virtual ScriptPromise read(ScriptState*) = 0;
ScriptPromise cancel(ScriptState*, ScriptValue reason);
- ScriptPromise closed(ScriptState*);
- virtual ScriptValue readInternal(ScriptState*, ExceptionState&) = 0;
- ScriptPromise readyInternal(ScriptState*);
+ virtual bool hasPendingReads() const = 0;
+ virtual void resolveAllPendingReadsAsDone() = 0;
+ virtual void rejectAllPendingReads(PassRefPtrWillBeRawPtr<DOMException>) = 0;
void close();
void error(PassRefPtrWillBeRawPtr<DOMException>);
@@ -77,13 +71,9 @@ public:
void stop() override;
DECLARE_VIRTUAL_TRACE();
- // Returns the string representation of the given State.
- static String stateToString(State);
-
protected:
bool enqueuePreliminaryCheck();
bool enqueuePostAction();
- void readInternalPreliminaryCheck(ExceptionState&);
void readInternalPostAction();
private:
@@ -103,9 +93,6 @@ private:
bool m_isPulling;
State m_state;
- Member<WaitPromise> m_ready;
- Member<ClosedPromise> m_closed;
-
RefPtrWillBeMember<DOMException> m_exception;
Member<ReadableStreamReader> m_reader;
};

Powered by Google App Engine
This is Rietveld 408576698