Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: Source/core/streams/ReadableStreamReader.h

Issue 1004623007: Streams Implementation Update: async read (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@stream-reader-read
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/streams/ReadableStreamImpl.h ('k') | Source/core/streams/ReadableStreamReader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/streams/ReadableStreamReader.h
diff --git a/Source/core/streams/ReadableStreamReader.h b/Source/core/streams/ReadableStreamReader.h
index e206998cd53f3add04d37d1f06639f48dc8ae1af..5f8e8317f6b72e1851518d75babef98796b1a171 100644
--- a/Source/core/streams/ReadableStreamReader.h
+++ b/Source/core/streams/ReadableStreamReader.h
@@ -21,9 +21,7 @@ class ExceptionState;
class ScriptState;
// ReadableStreamReader corresponds to the same-name class in the Streams spec
-// https://streams.spec.whatwg.org/. This class trusts ReadableStream, contrary
-// to the class in the Streams spec, because we only support
-// blink::Readable[Byte]Stream as this reader's customer.
+// https://streams.spec.whatwg.org/.
class ReadableStreamReader final : public GarbageCollectedFinalized<ReadableStreamReader>, public ScriptWrappable, public ActiveDOMObject {
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ReadableStreamReader);
@@ -33,12 +31,10 @@ public:
ScriptPromise closed(ScriptState*);
bool isActive() const;
- ScriptPromise ready(ScriptState*);
- String state() const;
ScriptPromise cancel(ScriptState*, ScriptValue reason);
- ScriptValue read(ScriptState*, ExceptionState&);
+ ScriptPromise read(ScriptState*);
+ void releaseLock(ExceptionState&);
void releaseLock();
- ScriptPromise released(ScriptState*);
bool hasPendingActivity() const override;
void stop() override;
@@ -46,15 +42,11 @@ public:
DECLARE_TRACE();
private:
- using ReleasedPromise = ScriptPromiseProperty<Member<ReadableStreamReader>, ToV8UndefinedGenerator, ToV8UndefinedGenerator>;
using ClosedPromise = ScriptPromiseProperty<Member<ReadableStreamReader>, ToV8UndefinedGenerator, RefPtrWillBeMember<DOMException>>;
- using ReadyPromise = ScriptPromiseProperty<Member<ReadableStreamReader>, ToV8UndefinedGenerator, ToV8UndefinedGenerator>;
const Member<ReadableStream> m_stream;
- const Member<ReleasedPromise> m_released;
ReadableStream::State m_stateAfterRelease;
- Member<ClosedPromise> m_closedAfterRelease;
- Member<ReadyPromise> m_readyAfterRelease;
+ Member<ClosedPromise> m_closed;
};
} // namespace blink
« no previous file with comments | « Source/core/streams/ReadableStreamImpl.h ('k') | Source/core/streams/ReadableStreamReader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698