Streams Implementation Update: async read

Source/core/streams/ReadableStream.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/streams/ReadableStream.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
@@ skipping 16 matching lines @@
     }
 
 private:
     explicit ConstUndefined(ScriptState* scriptState) : ScriptFunction(scriptState) { }
     ScriptValue call(ScriptValue value) override
     {
         return ScriptValue(scriptState(), v8::Undefined(scriptState()->isolate()));
     }
 };
 
-class ResolveWithReady : public ScriptFunction {
-public:
-    static v8::Handle<v8::Function> create(ScriptState* scriptState, ReadableStream* stream)
-    {
-        return (new ResolveWithReady(scriptState, stream))->bindToV8Function();
-    }
-
-    DEFINE_INLINE_TRACE()
-    {
-        visitor->trace(m_stream);
-        ScriptFunction::trace(visitor);
-    }
-
-private:
-    ResolveWithReady(ScriptState* scriptState, ReadableStream* stream)
-        : ScriptFunction(scriptState)
-        , m_stream(stream) { }
-
-    ScriptValue call(ScriptValue value) override
-    {
-        return ScriptValue(scriptState(), m_stream->ready(scriptState()).v8Value());
-    }
-
-    Member<ReadableStream> m_stream;
-};
-
 } // namespace
 
 ReadableStream::ReadableStream(ExecutionContext* executionContext, UnderlyingSource* source)
     : ActiveDOMObject(executionContext)
     , m_source(source)
     , m_isStarted(false)
     , m_isDraining(false)
     , m_isPulling(false)
-    , m_state(Waiting)
-    , m_ready(new WaitPromise(executionContext, this, WaitPromise::Ready))
-    , m_closed(new ClosedPromise(executionContext, this, ClosedPromise::Closed))
+    , m_state(Readable)
 {
     suspendIfNeeded();
 }
 
 ReadableStream::~ReadableStream()
 {
 }
 
-String ReadableStream::stateString() const
-{
-    if (m_reader)
-        return "waiting";
-
-    return stateToString(m_state);
-}
-
 bool ReadableStream::enqueuePreliminaryCheck()
 {
     // This is a bit different from what spec says: it says we should throw
     // an exception here. But sometimes a caller is not in any JavaScript
     // context, and we don't want to throw an exception in such a case.
     if (m_state == Errored || m_state == Closed || m_isDraining)
         return false;
 
     return true;
 }
 
 bool ReadableStream::enqueuePostAction()
 {
     m_isPulling = false;
 
     bool shouldApplyBackpressure = this->shouldApplyBackpressure();
     // this->shouldApplyBackpressure may call this->error().
     if (m_state == Errored)
         return false;
 
-    if (m_state == Waiting) {
-        // ReadableStream::hasPendingActivity return value gets false when
-        // |m_state| is changed to Closed or Errored from Waiting or Readable.
-        // On the other hand, the wrappers should be kept alive when |m_ready|
-        // and |m_close| resolution and rejection are called. Hence we call
-        // ScriptPromiseProperty::resolve and ScriptPromiseProperty::reject
-        // *before* changing state, no matter if the state change actually
-        // changes hasPendingActivity return value.
-        m_ready->resolve(ToV8UndefinedGenerator());
-        m_state = Readable;
-    }
-
     return !shouldApplyBackpressure;
 }
 
 void ReadableStream::close()
 {
-    if (m_state == Waiting) {
-        m_ready->resolve(ToV8UndefinedGenerator());
-        m_closed->resolve(ToV8UndefinedGenerator());
+    if (m_state != Readable)
+        return;
+
+    if (isQueueEmpty()) {
+        resolveAllPendingReadsAsDone();

[tyoshino (SeeGerritForStatus), 2015/03/18 07:39:10]

L83-L86 and L95-L99 are the same.

[yhirano, 2015/03/18 08:07:49]

Done.

+        m_state = Closed;
         if (m_reader)
             m_reader->releaseLock();
-        m_state = Closed;
-    } else if (m_state == Readable) {
+    } else {
         m_isDraining = true;
     }
 }
 
-void ReadableStream::readInternalPreliminaryCheck(ExceptionState& exceptionState)
-{
-    if (m_state == Waiting) {
-        exceptionState.throwTypeError("read is called while state is waiting");
-        return;
-    }
-    if (m_state == Closed) {
-        exceptionState.throwTypeError("read is called while state is closed");
-        return;
-    }
-    if (m_state == Errored) {
-        exceptionState.throwDOMException(m_exception->code(), m_exception->message());
-        return;
-    }
-}
-
 void ReadableStream::readInternalPostAction()
 {
     ASSERT(m_state == Readable);
-    if (isQueueEmpty()) {
-        if (m_isDraining) {
-            m_state = Closed;
-            m_closed->resolve(ToV8UndefinedGenerator());
-            if (m_reader)
-                m_reader->releaseLock();
-        } else {
-            m_ready->reset();
-            m_state = Waiting;
-        }
+    if (isQueueEmpty() && m_isDraining) {
+        m_state = Closed;

[tyoshino (SeeGerritForStatus), 2015/03/18 07:39:10]

this should be done after resolving the promises? L110-121 no longer applies?

[yhirano, 2015/03/18 08:07:49]

We don't have to care about it, because it is ScriptPromiseProperty related and
we don't have a ScriptPromiseProperty in ReadableStream now.

+        resolveAllPendingReadsAsDone();
+        if (m_reader)
+            m_reader->releaseLock();
     }
     callPullIfNeeded();
 }
 
-ScriptValue ReadableStream::read(ScriptState* scriptState, ExceptionState& exceptionState)
-{
-    if (m_reader) {
-        exceptionState.throwTypeError("this stream is locked to a ReadableStreamReader");
-        return ScriptValue();
-    }
-    return readInternal(scriptState, exceptionState);
-}
-
-ScriptPromise ReadableStream::ready(ScriptState* scriptState)
-{
-    if (m_reader) {
-        return m_reader->released(scriptState).then(ResolveWithReady::create(scriptState, this));
-    }
-
-    if (m_state == Waiting) {
-        return readyInternal(scriptState).then(ResolveWithReady::create(scriptState, this));
-    }
-    return readyInternal(scriptState);
-}
-
-ScriptPromise ReadableStream::readyInternal(ScriptState* scriptState)
-{
-    return m_ready->promise(scriptState->world());
-}
-
 ScriptPromise ReadableStream::cancel(ScriptState* scriptState, ScriptValue reason)
 {
     if (m_reader)
         return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "this stream is locked to a ReadableStreamReader"));
     if (m_state == Closed)
         return ScriptPromise::cast(scriptState, v8::Undefined(scriptState->isolate()));
     if (m_state == Errored)
         return ScriptPromise::rejectWithDOMException(scriptState, m_exception);
 
-    ASSERT(m_state == Readable || m_state == Waiting);
-    if (m_state == Waiting)
-        m_ready->resolve(ToV8UndefinedGenerator());
+    ASSERT(m_state == Readable);
     clearQueue();
-    m_closed->resolve(ToV8UndefinedGenerator());
     m_state = Closed;
+    resolveAllPendingReadsAsDone();
+
     return m_source->cancelSource(scriptState, reason).then(ConstUndefined::create(scriptState));
 }
 
-ScriptPromise ReadableStream::closed(ScriptState* scriptState)
-{
-    return m_closed->promise(scriptState->world());
-}
-
 void ReadableStream::error(PassRefPtrWillBeRawPtr<DOMException> exception)
 {
-    switch (m_state) {
-    case Waiting:
-        m_exception = exception;
-        m_ready->reject(m_exception);
-        m_closed->reject(m_exception);
-        m_state = Errored;
-        if (m_reader)
-            m_reader->releaseLock();
-        break;
-    case Readable:
-        clearQueue();
-        m_exception = exception;
-        m_ready->reset();
-        m_ready->reject(m_exception);
-        m_closed->reject(m_exception);
-        m_state = Errored;
-        if (m_reader)
-            m_reader->releaseLock();
-        break;
-    default:
-        break;
-    }
+    if (m_state != ReadableStream::Readable)
+        return;
+
+    m_exception = exception;
+    clearQueue();
+    rejectAllPendingReads(m_exception);
+    m_state = Errored;
+    if (m_reader)
+        m_reader->releaseLock();
 }
 
 void ReadableStream::didSourceStart()
 {
     m_isStarted = true;
     callPullIfNeeded();
 }
 
 ReadableStreamReader* ReadableStream::getReader(ExceptionState& exceptionState)
 {
-    if (m_state == Closed) {
-        exceptionState.throwTypeError("this stream is already closed");
-        return nullptr;
-    }
-    if (m_state == Errored) {
-        exceptionState.throwDOMException(m_exception->code(), m_exception->message());
-        return nullptr;
-    }
     if (m_reader) {
         exceptionState.throwTypeError("already locked to a ReadableStreamReader");
         return nullptr;
     }
     return new ReadableStreamReader(this);
 }
 
 void ReadableStream::setReader(ReadableStreamReader* reader)
 {
     ASSERT((reader && !m_reader) || (!reader && m_reader));
     m_reader = reader;
 }
 
 void ReadableStream::callPullIfNeeded()
 {
     if (m_isPulling || m_isDraining || !m_isStarted || m_state == Closed || m_state == Errored)
         return;
 
     bool shouldApplyBackpressure = this->shouldApplyBackpressure();
     // this->shouldApplyBackpressure may call this->error().
     if (shouldApplyBackpressure || m_state == Errored)
         return;
     m_isPulling = true;
     m_source->pullSource();
 }
 
 bool ReadableStream::hasPendingActivity() const
 {
-    return m_state == Waiting || m_state == Readable;
+    return m_state == Readable;
 }
 
 void ReadableStream::stop()
 {
     error(DOMException::create(AbortError, "execution context is stopped"));
     ActiveDOMObject::stop();
 }
 
 DEFINE_TRACE(ReadableStream)
 {
     visitor->trace(m_source);
-    visitor->trace(m_ready);
-    visitor->trace(m_closed);
     visitor->trace(m_exception);
     visitor->trace(m_reader);
     ActiveDOMObject::trace(visitor);
 }
 
-String ReadableStream::stateToString(State state)
-{
-    switch (state) {
-    case Readable:
-        return "readable";
-    case Waiting:
-        return "waiting";
-    case Closed:
-        return "closed";
-    case Errored:
-        return "errored";
-    }
-    ASSERT(false);
-    return String();
-}
-
 } // namespace blink