Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: content/public/common/resource_devtools_info.h

Issue 1004593005: base::RefCounted now DCHECKs when referenced from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lots of tests using UnsafeRefCounted. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/resource_devtools_info.h
diff --git a/content/public/common/resource_devtools_info.h b/content/public/common/resource_devtools_info.h
index bf17b1b6a82546a6d9d83189e1e5c422dd5db650..1f7d48e6121c94105b3d01932317338ac1b6b062 100644
--- a/content/public/common/resource_devtools_info.h
+++ b/content/public/common/resource_devtools_info.h
@@ -17,7 +17,8 @@ namespace content {
// Note: when modifying this structure, also update DeepCopy in
// resource_devtools_info.cc.
-struct ResourceDevToolsInfo : base::RefCounted<ResourceDevToolsInfo> {
+// TODO(mgiuca): Avoid using UnsafeRefCounted. http://crbug.com/469952.
+struct ResourceDevToolsInfo : base::UnsafeRefCounted<ResourceDevToolsInfo> {
typedef base::StringPairs HeadersVector;
CONTENT_EXPORT ResourceDevToolsInfo();
@@ -32,7 +33,7 @@ struct ResourceDevToolsInfo : base::RefCounted<ResourceDevToolsInfo> {
std::string response_headers_text;
private:
- friend class base::RefCounted<ResourceDevToolsInfo>;
+ friend class base::UnsafeRefCounted<ResourceDevToolsInfo>;
CONTENT_EXPORT ~ResourceDevToolsInfo();
};

Powered by Google App Engine
This is Rietveld 408576698