Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3020)

Unified Diff: base/deferred_sequenced_task_runner_unittest.cc

Issue 1004593005: base::RefCounted now DCHECKs when referenced from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lots of tests using UnsafeRefCounted. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/memory/ref_counted.h » ('j') | base/memory/ref_counted.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/deferred_sequenced_task_runner_unittest.cc
diff --git a/base/deferred_sequenced_task_runner_unittest.cc b/base/deferred_sequenced_task_runner_unittest.cc
index 81f2a0a00c9beb39b0934ce4e942d6bfd9671837..cc07326e2a0b5cc92cfb73900e4ba27e31e7efe3 100644
--- a/base/deferred_sequenced_task_runner_unittest.cc
+++ b/base/deferred_sequenced_task_runner_unittest.cc
@@ -20,8 +20,9 @@ namespace {
class DeferredSequencedTaskRunnerTest : public testing::Test,
public base::NonThreadSafe {
public:
+ // TODO(mgiuca): Avoid using UnsafeRefCounted. http://crbug.com/469952.
class ExecuteTaskOnDestructor :
- public base::RefCounted<ExecuteTaskOnDestructor> {
+ public base::UnsafeRefCounted<ExecuteTaskOnDestructor> {
public:
ExecuteTaskOnDestructor(
DeferredSequencedTaskRunnerTest* executor,
@@ -30,7 +31,7 @@ class DeferredSequencedTaskRunnerTest : public testing::Test,
task_id_(task_id) {
}
private:
- friend class base::RefCounted<ExecuteTaskOnDestructor>;
+ friend class base::UnsafeRefCounted<ExecuteTaskOnDestructor>;
virtual ~ExecuteTaskOnDestructor() {
executor_->ExecuteTask(task_id_);
}
« no previous file with comments | « no previous file | base/memory/ref_counted.h » ('j') | base/memory/ref_counted.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698