Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: ui/gl/gl_share_group.h

Issue 1004593005: base::RefCounted now DCHECKs when referenced from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lots of tests using UnsafeRefCounted. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« base/memory/ref_counted.h ('K') | « ui/gfx/image/image.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_GL_GL_SHARE_GROUP_H_ 5 #ifndef UI_GL_GL_SHARE_GROUP_H_
6 #define UI_GL_GL_SHARE_GROUP_H_ 6 #define UI_GL_GL_SHARE_GROUP_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "ui/gl/gl_export.h" 12 #include "ui/gl/gl_export.h"
13 13
14 namespace gfx { 14 namespace gfx {
15 15
16 class GLContext; 16 class GLContext;
17 17
18 // A group of GL contexts that share an ID namespace. 18 // A group of GL contexts that share an ID namespace.
19 class GL_EXPORT GLShareGroup : public base::RefCounted<GLShareGroup> { 19 // TODO(mgiuca): Avoid using UnsafeRefCounted. http://crbug.com/469952.
20 class GL_EXPORT GLShareGroup : public base::UnsafeRefCounted<GLShareGroup> {
20 public: 21 public:
21 GLShareGroup(); 22 GLShareGroup();
22 23
23 // These two should only be called from the constructor and destructor of 24 // These two should only be called from the constructor and destructor of
24 // GLContext. 25 // GLContext.
25 void AddContext(GLContext* context); 26 void AddContext(GLContext* context);
26 void RemoveContext(GLContext* context); 27 void RemoveContext(GLContext* context);
27 28
28 // Returns a handle to any initialized context in the share group or NULL if 29 // Returns a handle to any initialized context in the share group or NULL if
29 // there are no initialized contexts in the share group. 30 // there are no initialized contexts in the share group.
30 void* GetHandle(); 31 void* GetHandle();
31 32
32 // Returns a pointer to any initialized context in the share group 33 // Returns a pointer to any initialized context in the share group
33 // or NULL if there are no initialized contexts in the share group. 34 // or NULL if there are no initialized contexts in the share group.
34 GLContext* GetContext(); 35 GLContext* GetContext();
35 36
36 // Sets and returns the unique shared GL context. Used for context 37 // Sets and returns the unique shared GL context. Used for context
37 // virtualization. 38 // virtualization.
38 void SetSharedContext(GLContext* context); 39 void SetSharedContext(GLContext* context);
39 GLContext* GetSharedContext(); 40 GLContext* GetSharedContext();
40 41
41 #if defined(OS_MACOSX) 42 #if defined(OS_MACOSX)
42 // Sets and returns the ID of the renderer that all contexts in this share 43 // Sets and returns the ID of the renderer that all contexts in this share
43 // group should be on. 44 // group should be on.
44 void SetRendererID(int renderer_id); 45 void SetRendererID(int renderer_id);
45 int GetRendererID(); 46 int GetRendererID();
46 #endif 47 #endif
47 48
48 private: 49 private:
49 friend class base::RefCounted<GLShareGroup>; 50 friend class base::UnsafeRefCounted<GLShareGroup>;
50 51
51 ~GLShareGroup(); 52 ~GLShareGroup();
52 53
53 // References to GLContext are by raw pointer to avoid a reference count 54 // References to GLContext are by raw pointer to avoid a reference count
54 // cycle. 55 // cycle.
55 typedef std::set<GLContext*> ContextSet; 56 typedef std::set<GLContext*> ContextSet;
56 ContextSet contexts_; 57 ContextSet contexts_;
57 58
58 GLContext* shared_context_; 59 GLContext* shared_context_;
59 60
60 #if defined(OS_MACOSX) 61 #if defined(OS_MACOSX)
61 int renderer_id_; 62 int renderer_id_;
62 #endif 63 #endif
63 64
64 DISALLOW_COPY_AND_ASSIGN(GLShareGroup); 65 DISALLOW_COPY_AND_ASSIGN(GLShareGroup);
65 }; 66 };
66 67
67 } // namespace gfx 68 } // namespace gfx
68 69
69 #endif // UI_GL_GL_SHARE_GROUP_H_ 70 #endif // UI_GL_GL_SHARE_GROUP_H_
OLDNEW
« base/memory/ref_counted.h ('K') | « ui/gfx/image/image.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698