Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: gpu/command_buffer/common/value_state.h

Issue 1004593005: base::RefCounted now DCHECKs when referenced from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lots of tests using UnsafeRefCounted. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GPU_COMMAND_BUFFER_COMMON_VALUE_STATE_H_ 5 #ifndef GPU_COMMAND_BUFFER_COMMON_VALUE_STATE_H_
6 #define GPU_COMMAND_BUFFER_COMMON_VALUE_STATE_H_ 6 #define GPU_COMMAND_BUFFER_COMMON_VALUE_STATE_H_
7 7
8 #include "base/containers/hash_tables.h" 8 #include "base/containers/hash_tables.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "gpu/gpu_export.h" 10 #include "gpu/gpu_export.h"
11 11
12 namespace gpu { 12 namespace gpu {
13 13
14 // Used to maintain Valuebuffer state, exposed to browser to 14 // Used to maintain Valuebuffer state, exposed to browser to
15 // support passing ValueStates via IPC. 15 // support passing ValueStates via IPC.
16 union GPU_EXPORT ValueState { 16 union GPU_EXPORT ValueState {
17 float float_value[4]; 17 float float_value[4];
18 int int_value[4]; 18 int int_value[4];
19 }; 19 };
20 20
21 // Refcounted wrapper for a hash_map of subscription targets to ValueStates 21 // Refcounted wrapper for a hash_map of subscription targets to ValueStates
22 class GPU_EXPORT ValueStateMap : public base::RefCounted<ValueStateMap> { 22 // TODO(mgiuca): Avoid using UnsafeRefCounted. http://crbug.com/469952.
23 class GPU_EXPORT ValueStateMap : public base::UnsafeRefCounted<ValueStateMap> {
23 public: 24 public:
24 ValueStateMap(); 25 ValueStateMap();
25 26
26 // Returns NULL if there is not ValueState for the target 27 // Returns NULL if there is not ValueState for the target
27 const ValueState* GetState(unsigned int target) const; 28 const ValueState* GetState(unsigned int target) const;
28 29
29 void UpdateState(unsigned int target, const ValueState& state); 30 void UpdateState(unsigned int target, const ValueState& state);
30 31
31 protected: 32 protected:
32 virtual ~ValueStateMap(); 33 virtual ~ValueStateMap();
33 34
34 private: 35 private:
35 friend class base::RefCounted<ValueStateMap>; 36 friend class base::UnsafeRefCounted<ValueStateMap>;
36 37
37 typedef base::hash_map<unsigned int, ValueState> Map; 38 typedef base::hash_map<unsigned int, ValueState> Map;
38 39
39 Map state_map_; 40 Map state_map_;
40 41
41 DISALLOW_COPY_AND_ASSIGN(ValueStateMap); 42 DISALLOW_COPY_AND_ASSIGN(ValueStateMap);
42 }; 43 };
43 44
44 } // namespace gpu 45 } // namespace gpu
45 46
46 #endif // GPU_COMMAND_BUFFER_COMMON_VALUE_STATE_H_ 47 #endif // GPU_COMMAND_BUFFER_COMMON_VALUE_STATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698