Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1004593004: Re-enable CrossSiteIframeBecomesSameSite. (Closed)

Created:
5 years, 9 months ago by ncarter (slow)
Modified:
5 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable CrossSiteIframeBecomesSameSite. This test passes now because bug 433012 has been fixed in blink. BUG=433012 Committed: https://crrev.com/fa053d26ec57479dc4beeb5c3f1d051c19d12393 Cr-Commit-Position: refs/heads/master@{#321902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
Nasko, please review
5 years, 9 months ago (2015-03-23 21:42:29 UTC) #2
nasko
LGTM
5 years, 9 months ago (2015-03-23 23:01:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004593004/1
5 years, 9 months ago (2015-03-23 23:16:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 00:03:42 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 00:04:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa053d26ec57479dc4beeb5c3f1d051c19d12393
Cr-Commit-Position: refs/heads/master@{#321902}

Powered by Google App Engine
This is Rietveld 408576698