Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 100453010: Add base:: to string16s in android_webview/. (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Add base:: to string16s in android_webview/. R=benm@chromium.org BUG=329295 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -69 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M android_webview/browser/aw_contents_client_bridge_base.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/browser/aw_javascript_dialog_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/browser/aw_javascript_dialog_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/aw_login_delegate.h View 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/browser/aw_login_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M android_webview/browser/find_helper.h View 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/find_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/net/aw_network_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net/aw_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/aw_content_client.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/aw_content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/aw_hit_test_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/common/print_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/common/print_messages.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/common/render_view_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_autofill_manager_delegate.h View 3 chunks +6 lines, -6 lines 0 comments Download
M android_webview/native/aw_autofill_manager_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/state_serializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/state_serializer_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/aw_content_renderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/aw_render_view_ext.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dan Beam
7 years ago (2013-12-19 06:04:31 UTC) #1
mnaganov (inactive)
On 2013/12/19 06:04:31, Dan Beam wrote: The change looks pretty mechanical, but I'm wondering why ...
7 years ago (2013-12-19 09:29:43 UTC) #2
mnaganov (inactive)
OK, unit_tests are fine this time. LGTM, thanks for cleaning this stuff up!
7 years ago (2013-12-19 10:28:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/100453010/1
7 years ago (2013-12-19 17:27:58 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=42274
7 years ago (2013-12-19 17:47:48 UTC) #5
Dan Beam
+tsepez@ for *messages*
7 years ago (2013-12-19 17:51:24 UTC) #6
Tom Sepez
On 2013/12/19 17:51:24, Dan Beam wrote: > +tsepez@ for *messages* Rubberstanp LGTM.
7 years ago (2013-12-19 19:29:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/100453010/1
7 years ago (2013-12-19 19:37:37 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-19 22:44:52 UTC) #9
Message was sent while issue was closed. 
Change committed as 241958

Powered by Google App Engine
This is Rietveld 408576698