Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 100453006: Move Touch to base namespace, remove SetLastModifiedTime. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
viettrungluu
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, tzik, jam, nhiroki, joi+watch-content_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, markusheintz_, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+watch, davemoore+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Move Touch to base namespace, remove SetLastModifiedTime. This implements callers of SetLastModifiedTime in terms of base::Touch. SetLastModifiedTime was just a shorthand for touch that confusingly set both the last modified and last access times, and was only used by 7 files. It seems better to just have the callers call Touch directly. BUG= R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238803

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -72 lines) Patch
M base/file_util.h View 1 chunk +5 lines, -9 lines 0 comments Download
M base/file_util.cc View 1 chunk +17 lines, -23 lines 0 comments Download
M base/file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/files/file_util_proxy.cc View 1 chunk +1 line, -2 lines 2 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 chunk +12 lines, -8 lines 1 comment Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 1 chunk +10 lines, -6 lines 1 comment Download
M net/disk_cache/simple/simple_index_file_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/local_file_stream_reader_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/database/database_tracker_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M webkit/browser/fileapi/native_file_util.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
This actually removes a function so don't rubberstamp.
7 years ago (2013-12-04 20:35:48 UTC) #1
viettrungluu
LGTM w/nit. https://codereview.chromium.org/100453006/diff/1/base/files/file_util_proxy.cc File base/files/file_util_proxy.cc (right): https://codereview.chromium.org/100453006/diff/1/base/files/file_util_proxy.cc#newcode360 base/files/file_util_proxy.cc:360: Bind(&base::TouchFile, file_path, last_access_time, last_modified_time), nit: you're already ...
7 years ago (2013-12-04 21:09:22 UTC) #2
brettw
https://codereview.chromium.org/100453006/diff/1/base/files/file_util_proxy.cc File base/files/file_util_proxy.cc (right): https://codereview.chromium.org/100453006/diff/1/base/files/file_util_proxy.cc#newcode360 base/files/file_util_proxy.cc:360: Bind(&base::TouchFile, file_path, last_access_time, last_modified_time), I'll get around to removing ...
7 years ago (2013-12-04 21:38:17 UTC) #3
brettw
7 years ago (2013-12-04 22:49:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r238803.

Powered by Google App Engine
This is Rietveld 408576698