Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: remoting/webapp/crd/js/dns_blackhole_checker_unittest.js

Issue 1004513002: Eliminated named constants for instances of remoting.Error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/dns_blackhole_checker_unittest.js
diff --git a/remoting/webapp/crd/js/dns_blackhole_checker_unittest.js b/remoting/webapp/crd/js/dns_blackhole_checker_unittest.js
index dafa2c2bf997bf3d6c8b4c235ed7123a94928983..55ed64ccd256cdbf334e95c1aa8e19e5db196aa6 100644
--- a/remoting/webapp/crd/js/dns_blackhole_checker_unittest.js
+++ b/remoting/webapp/crd/js/dns_blackhole_checker_unittest.js
@@ -5,7 +5,7 @@
/**
* @fileoverview
* TODO(garykac): Create interface for SignalStrategy.
- * @suppress {checkTypes|checkVars|reportUnknownTypes|visibility}
+ * @suppress {accessControls|checkTypes|checkVars|reportUnknownTypes|visibility}
Jamie 2015/03/13 17:56:17 Do you need to suppress accessControls if you're u
John Williams 2015/03/13 19:30:29 Nope, meant to remove that.
*/
(function() {
@@ -125,7 +125,7 @@ test('blocked',
fakeXhrs[0].respond(400);
sinon.assert.calledWith(onStateChange,
remoting.SignalStrategy.State.FAILED);
- equal(checker.getError().tag, remoting.Error.Tag.NOT_AUTHORIZED);
+ ok(checker.getError().hasTag(remoting.Error.Tag.NOT_AUTHORIZED));
onStateChange.reset();
[
@@ -163,7 +163,7 @@ test('blocked after connected',
fakeXhrs[0].respond(400);
sinon.assert.calledWith(onStateChange,
remoting.SignalStrategy.State.FAILED);
- equal(checker.getError().tag, remoting.Error.Tag.NOT_AUTHORIZED);
+ ok(checker.getError().hasTag(remoting.Error.Tag.NOT_AUTHORIZED));
}
);

Powered by Google App Engine
This is Rietveld 408576698