remoting/webapp/crd/js/dns_blackhole_checker_unittest.js - Issue 1004513002: Eliminated named constants for instances of remoting.Error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/dns_blackhole_checker_unittest.js

Issue 1004513002: Eliminated named constants for instances of remoting.Error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/crd/js/dns_blackhole_checker_unittest.js

diff --git a/remoting/webapp/crd/js/dns_blackhole_checker_unittest.js b/remoting/webapp/crd/js/dns_blackhole_checker_unittest.js

index dafa2c2bf997bf3d6c8b4c235ed7123a94928983..6c553458d8bccca3ed07ce71a33716fe7199f056 100644

--- a/remoting/webapp/crd/js/dns_blackhole_checker_unittest.js

+++ b/remoting/webapp/crd/js/dns_blackhole_checker_unittest.js

@@ -125,7 +125,7 @@ test('blocked',

fakeXhrs[0].respond(400);

sinon.assert.calledWith(onStateChange,

remoting.SignalStrategy.State.FAILED);

- equal(checker.getError().tag, remoting.Error.Tag.NOT_AUTHORIZED);

+ equal(checker.getError().getTag(), remoting.Error.Tag.NOT_AUTHORIZED);

onStateChange.reset();

[

@@ -163,7 +163,7 @@ test('blocked after connected',

fakeXhrs[0].respond(400);

sinon.assert.calledWith(onStateChange,

remoting.SignalStrategy.State.FAILED);

- equal(checker.getError().tag, remoting.Error.Tag.NOT_AUTHORIZED);

+ ok(checker.getError().hasTag(remoting.Error.Tag.NOT_AUTHORIZED));

}

);

« no previous file with comments | « remoting/webapp/crd/js/dns_blackhole_checker.js ('k') | remoting/webapp/crd/js/error.js » ('j') | no next file with comments »