remoting/webapp/crd/js/server_log_entry.js - Issue 1004513002: Eliminated named constants for instances of remoting.Error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/server_log_entry.js

Issue 1004513002: Eliminated named constants for instances of remoting.Error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/crd/js/server_log_entry.js

diff --git a/remoting/webapp/crd/js/server_log_entry.js b/remoting/webapp/crd/js/server_log_entry.js

index 6a6dd0f4aeda267e18337ea3c31d17b0e5783c18..130056c8aeaa2a78f2de5c4905117ec8f821ba2c 100644

--- a/remoting/webapp/crd/js/server_log_entry.js

+++ b/remoting/webapp/crd/js/server_log_entry.js

@@ -231,7 +231,7 @@ remoting.ServerLogEntry.makeClientSessionStateChange = function(state,

remoting.ServerLogEntry.VALUE_EVENT_NAME_SESSION_STATE_);

entry.set_(remoting.ServerLogEntry.KEY_SESSION_STATE_,

remoting.ServerLogEntry.getValueForSessionState_(state));

- if (connectionError.tag != remoting.Error.NONE) {

+ if (connectionError.tag.isError()) {

Jamie 2015/03/11 22:16:38 isError() is a method on Error, not Tag?

John Williams 2015/03/12 02:46:20 Done.

entry.set_(remoting.ServerLogEntry.KEY_CONNECTION_ERROR_,

remoting.ServerLogEntry.getValueForError_(connectionError));

}

« remoting/webapp/crd/js/error.js ('K') | « remoting/webapp/crd/js/oauth2_api_impl.js ('k') | remoting/webapp/crd/js/session_connector_impl.js » ('j') | no next file with comments »