Eliminated named constants for instances of remoting.Error.

remoting/webapp/crd/js/l10n.js

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 var l10n = l10n || {};
 
 /**
  * Localize a tag, returning the tag itself and logging an error if no
  * translation exists.
@@ skipping 10 matching lines @@
   }
   console.error('Missing translation for "' + tag + '"');
   return tag;
 };
 
 /**
  * Localize an element by setting its innerText according to the specified tag
  * and an optional set of substitutions.
  *
  * @param {Element} element The element to localize.
- * @param {string} tag The localization tag.
+ * @param {string|remoting.Error} tagOrError The localization tag or
+ *     an Error object containing the tag.

[Jamie, 2015/03/13 17:56:17]

This should just be a string, and the caller should be responsible for
extracting the tag from an Error.

[Jamie, 2015/03/13 20:26:01]

Please address this comment.

[John Williams, 2015/03/13 22:40:30]

Done.

  * @param {(string|Array)=} opt_substitutions An optional set of substitution
  *     strings corresponding to the "placeholders" attributes in messages.json.
  * @param {boolean=} opt_asHtml If true, set innerHTML instead of innerText.
  *     This parameter should be used with caution.
  * @return {boolean} True if the localization was successful; false otherwise.
  */
-l10n.localizeElementFromTag = function(element, tag, opt_substitutions,
+l10n.localizeElementFromTag = function(element, tagOrError, opt_substitutions,
                                        opt_asHtml) {
+  if (tagOrError == null) {
+    return false;
+  }
+  var tag = typeof tagOrError == 'string' ?
+      /** @type {string} */ (tagOrError) :
+      tagOrError.getTagForLocalization();
   var translation = l10n.getTranslationOrError(tag, opt_substitutions);
   if (opt_asHtml) {
     element.innerHTML = translation;
   } else {
     element.innerText = translation;
   }
   return translation != null;
 };
 
 /**
@@ skipping 46 matching lines @@
     }
     var titleTag = element.getAttribute('i18n-title');
     if (titleTag) {
       element.title = l10n.getTranslationOrError(titleTag, substitutions);
     } else {
       l10n.localizeElement(element, substitutions,
                            substitutions.length != 0);
     }
   }
 };