Eliminated named constants for instances of remoting.Error.

remoting/webapp/crd/js/dns_blackhole_checker_unittest.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * TODO(garykac): Create interface for SignalStrategy.
- * @suppress {checkTypes|checkVars|reportUnknownTypes|visibility}
+ * @suppress {accessControls|checkTypes|checkVars|reportUnknownTypes|visibility}

[Jamie, 2015/03/13 17:56:17]

Do you need to suppress accessControls if you're using hasTag?

[John Williams, 2015/03/13 19:30:29]

Nope, meant to remove that.

  */
 
 (function() {
 
 'use strict';
 
 /** @type {(sinon.Spy|function(remoting.SignalStrategy.State))} */
 var onStateChange = null;
 
 /** @type {(sinon.Spy|function(Element):void)} */
@@ skipping 99 matching lines @@
       sinon.assert.calledWith(onStateChange, state);
     });
 }
 );
 
 test('blocked',
   function() {
     fakeXhrs[0].respond(400);
     sinon.assert.calledWith(onStateChange,
                             remoting.SignalStrategy.State.FAILED);
-    equal(checker.getError().tag, remoting.Error.Tag.NOT_AUTHORIZED);
+    ok(checker.getError().hasTag(remoting.Error.Tag.NOT_AUTHORIZED));
     onStateChange.reset();
 
     [
       remoting.SignalStrategy.State.CONNECTING,
       remoting.SignalStrategy.State.HANDSHAKE,
       remoting.SignalStrategy.State.CONNECTED
     ].forEach(function(state) {
       signalStrategy.setStateForTesting(state);
       sinon.assert.notCalled(onStateChange);
       equal(checker.getState(), remoting.SignalStrategy.State.FAILED);
@@ skipping 17 matching lines @@
     // signal strategy has connected.
     signalStrategy.setStateForTesting(remoting.SignalStrategy.State.CONNECTED);
     sinon.assert.notCalled(onStateChange);
     equal(checker.getState(), remoting.SignalStrategy.State.HANDSHAKE);
 
     // Verify that DnsBlackholeChecker goes to FAILED state after it gets the
     // blocked HTTP response.
     fakeXhrs[0].respond(400);
     sinon.assert.calledWith(onStateChange,
                             remoting.SignalStrategy.State.FAILED);
-    equal(checker.getError().tag, remoting.Error.Tag.NOT_AUTHORIZED);
+    ok(checker.getError().hasTag(remoting.Error.Tag.NOT_AUTHORIZED));
   }
 );
 
 })();