Eliminated named constants for instances of remoting.Error.

remoting/webapp/crd/js/xmpp_login_handler_unittest.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 'use strict';
 
 var testUsername = 'testUsername@gmail.com';
 var testToken = 'testToken';
@@ skipping 144 matching lines @@
   sinon.assert.calledWith(startTls);
 });
 
 test('should return AUTHENTICATION_FAILED error when failed to authenticate',
      function() {
   handshakeBase();
 
   loginHandler.onDataReceived(
       base.encodeUtf8('<failure xmlns="urn:ietf:params:xml:ns:xmpp-sasl">' +
                       '<not-authorized/></failure>'));
-  sinon.assert.calledWith(onError, remoting.Error.AUTHENTICATION_FAILED);
+  sinon.assert.calledWith(onError, new remoting.Error(
+      remoting.Error.Tag.AUTHENTICATION_FAILED));

[Jamie, 2015/03/12 21:40:11]

Does this work? Can calledWith match two error instances that have the same tag,
but were created with separate calls to new?

[John Williams, 2015/03/13 00:26:35]

The tests pass, so I assume this method is doing a deep comparison.

 });
 
 test('should return UNEXPECTED error when failed to parse stream',
      function() {
   handshakeBase();
   loginHandler.onDataReceived(
       base.encodeUtf8('BAD DATA'));
-  sinon.assert.calledWith(onError, remoting.Error.UNEXPECTED);
+  sinon.assert.calledWith(onError, remoting.Error.unexpected());
 });
 
 })();