Eliminated named constants for instances of remoting.Error.

remoting/webapp/crd/js/server_log_entry.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * A class of server log entries.
  *
  * Any changes to the values here need to be coordinated with the host and
  * server/log proto code.
@@ skipping 73 matching lines @@
 remoting.ServerLogEntry.KEY_CONNECTION_ERROR_ = 'connection-error';
 
 /**
  * @private
  * @param {!remoting.Error} connectionError
  * @return {string}
  */
 remoting.ServerLogEntry.getValueForError_ = function(connectionError) {
   // Directory service should be updated if a new string is added here as
   // otherwise the error code will be ignored (i.e. recorded as 0 instead).
-  switch (connectionError.tag) {
+  switch (connectionError.getTag()) {
     case remoting.Error.Tag.NONE:
       return 'none';
     case remoting.Error.Tag.INVALID_ACCESS_CODE:
       return 'invalid-access-code';
     case remoting.Error.Tag.MISSING_PLUGIN:
       return 'missing_plugin';
     case remoting.Error.Tag.AUTHENTICATION_FAILED:
       return 'authentication-failed';
     case remoting.Error.Tag.HOST_IS_OFFLINE:
       return 'host-is-offline';
     case remoting.Error.Tag.INCOMPATIBLE_PROTOCOL:
       return 'incompatible-protocol';
     case remoting.Error.Tag.BAD_PLUGIN_VERSION:
       return 'bad-plugin-version';
     case remoting.Error.Tag.NETWORK_FAILURE:
       return 'network-failure';
     case remoting.Error.Tag.HOST_OVERLOAD:
       return 'host-overload';
     case remoting.Error.Tag.P2P_FAILURE:
       return 'p2p-failure';
     case remoting.Error.Tag.UNEXPECTED:
       return 'unexpected';
     default:
-      return 'unknown-' + connectionError;
+      return 'unknown-' + connectionError.getTag();
   }
 };
 
-
 /** @private */
 remoting.ServerLogEntry.VALUE_EVENT_NAME_CONNECTION_STATISTICS_ =
     "connection-statistics";
 /** @private */
 remoting.ServerLogEntry.KEY_VIDEO_BANDWIDTH_ = "video-bandwidth";
 /** @private */
 remoting.ServerLogEntry.KEY_CAPTURE_LATENCY_ = "capture-latency";
 /** @private */
 remoting.ServerLogEntry.KEY_ENCODE_LATENCY_ = "encode-latency";
 /** @private */
@@ skipping 91 matching lines @@
  */
 remoting.ServerLogEntry.makeClientSessionStateChange = function(state,
     connectionError, mode) {
   var entry = new remoting.ServerLogEntry();
   entry.set_(remoting.ServerLogEntry.KEY_ROLE_,
              remoting.ServerLogEntry.VALUE_ROLE_CLIENT_);
   entry.set_(remoting.ServerLogEntry.KEY_EVENT_NAME_,
              remoting.ServerLogEntry.VALUE_EVENT_NAME_SESSION_STATE_);
   entry.set_(remoting.ServerLogEntry.KEY_SESSION_STATE_,
              remoting.ServerLogEntry.getValueForSessionState_(state));
-  if (connectionError.tag != remoting.Error.NONE) {
+  if (!connectionError.isNone()) {
     entry.set_(remoting.ServerLogEntry.KEY_CONNECTION_ERROR_,
                remoting.ServerLogEntry.getValueForError_(connectionError));
   }
   entry.addModeField(mode);
   return entry;
 };
 
 /**
  * Makes a log entry for a set of connection statistics.
  * Returns null if all the statistics were zero.
@@ skipping 259 matching lines @@
     case remoting.DesktopConnectedView.Mode.IT2ME:
       return remoting.ServerLogEntry.VALUE_MODE_IT2ME_;
     case remoting.DesktopConnectedView.Mode.ME2ME:
       return remoting.ServerLogEntry.VALUE_MODE_ME2ME_;
     case remoting.DesktopConnectedView.Mode.APP_REMOTING:
       return remoting.ServerLogEntry.VALUE_MODE_APP_REMOTING_;
     default:
       return remoting.ServerLogEntry.VALUE_MODE_UNKNOWN_;
   }
 };