Eliminated named constants for instances of remoting.Error.

remoting/webapp/app_remoting/js/app_remoting.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * This class implements the functionality that is specific to application
  * remoting ("AppRemoting" or AR).
  */
 
@@ skipping 130 matching lines @@
          */
         var fetchThirdPartyToken = function(
             tokenUrl, hostPublicKey, scope, onThirdPartyTokenFetched) {
           // Use the authentication tokens returned by the app-remoting server.
           onThirdPartyTokenFetched(host['authorizationCode'],
                                    host['sharedSecret']);
         };
 
         connector.connectMe2App(host, fetchThirdPartyToken);
       } else if (response && response.status == 'pending') {
-        that.handleError(remoting.Error.SERVICE_UNAVAILABLE);
+        that.handleError(new remoting.Error(
+            remoting.Error.Tag.SERVICE_UNAVAILABLE));
       }
     } else {
       console.error('Invalid "runApplication" response from server.');
       // TODO(garykac) Start using remoting.Error.fromHttpStatus once it has
       // been updated to properly report 'unknown' errors (rather than
       // reporting them as AUTHENTICATION_FAILED).
       if (xhr.status == 0) {
-        that.handleError(remoting.Error.NETWORK_FAILURE);
+        that.handleError(new remoting.Error(
+            remoting.Error.Tag.NETWORK_FAILURE));
       } else if (xhr.status == 401) {
-        that.handleError(remoting.Error.AUTHENTICATION_FAILED);
+        that.handleError(new remoting.Error(
+            remoting.Error.Tag.AUTHENTICATION_FAILED));
       } else if (xhr.status == 403) {
-        that.handleError(remoting.Error.APP_NOT_AUTHORIZED);
+        that.handleError(new remoting.Error(
+            remoting.Error.Tag.APP_NOT_AUTHORIZED));
       } else if (xhr.status == 502 || xhr.status == 503) {
-        that.handleError(remoting.Error.SERVICE_UNAVAILABLE);
+        that.handleError(new remoting.Error(
+            remoting.Error.Tag.SERVICE_UNAVAILABLE));
       } else {
-        that.handleError(remoting.Error.UNEXPECTED);
+        that.handleError(remoting.Error.unexpected());
       }
     }
   };
 
   remoting.xhr.start({
     method: 'POST',
     url: that.runApplicationUrl(),
     onDone: parseAppHostResponse,
     oauthToken: token
   });
@@ skipping 147 matching lines @@
   return false;
 };
 
 /**
  * Called when an error needs to be displayed to the user.
  *
  * @param {!remoting.Error} error The error to be localized and displayed.
  * @return {void} Nothing.
  */
 remoting.AppRemoting.prototype.handleError = function(error) {
-  console.error('Connection failed: ' + error.tag);
+  console.error('Connection failed: ' + error.toString());
   remoting.LoadingWindow.close();
   remoting.MessageWindow.showErrorMessage(
       chrome.i18n.getMessage(/*i18n-content*/'CONNECTION_FAILED'),
-      chrome.i18n.getMessage(/** @type {string} */ (error.tag)));
+      chrome.i18n.getMessage(error.getTag()));
 };
 
 /**
  * Close the loading window before exiting.
  */
 remoting.AppRemoting.prototype.handleExit = function() {
   remoting.LoadingWindow.close();
 };