Eliminated named constants for instances of remoting.Error.

remoting/webapp/crd/js/oauth2_api_impl.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * OAuth2 API flow implementations.
  */
 
 /** @suppress {duplicate} */
@@ skipping 30 matching lines @@
  *
  * @private
  * @param {number} xhrStatus Status (HTTP response code) of the XMLHttpRequest.
  * @return {!remoting.Error} An error code to be raised.
  */
 remoting.OAuth2ApiImpl.prototype.interpretXhrStatus_ =
     function(xhrStatus) {
   // Return AUTHENTICATION_FAILED by default, so that the user can try to
   // recover from an unexpected failure by signing in again.
   /** @type {!remoting.Error} */
-  var error = remoting.Error.AUTHENTICATION_FAILED;
+  var error = new remoting.Error(remoting.Error.Tag.AUTHENTICATION_FAILED);
   if (xhrStatus == 400 || xhrStatus == 401 || xhrStatus == 403) {
-    error = remoting.Error.AUTHENTICATION_FAILED;
+    error = new remoting.Error(remoting.Error.Tag.AUTHENTICATION_FAILED);
   } else if (xhrStatus == 502 || xhrStatus == 503) {
-    error = remoting.Error.SERVICE_UNAVAILABLE;
+    error = new remoting.Error(remoting.Error.Tag.SERVICE_UNAVAILABLE);
   } else if (xhrStatus == 0) {
-    error = remoting.Error.NETWORK_FAILURE;
+    error = new remoting.Error(remoting.Error.Tag.NETWORK_FAILURE);
   } else {
     console.warn('Unexpected authentication response code: ' + xhrStatus);
   }
   return error;
 };
 
 /**
  * Asynchronously retrieves a new access token from the server.
  *
  * @param {function(string, number): void} onDone Callback to invoke when
@@ skipping 11 matching lines @@
   var onResponse = function(xhr) {
     if (xhr.status == 200) {
       try {
         // Don't use base.jsonParseSafe here unless you also include base.js,
         // otherwise this won't work from the OAuth trampoline.
         // TODO(jamiewalch): Fix this once we're no longer using the trampoline.
         var tokens = JSON.parse(xhr.responseText);
         onDone(tokens['access_token'], tokens['expires_in']);
       } catch (/** @type {Error} */ err) {
         console.error('Invalid "token" response from server:', err);
-        onError(remoting.Error.UNEXPECTED);
+        onError(remoting.Error.unexpected());
       }
     } else {
       console.error('Failed to refresh token. Status: ' + xhr.status +
                     ' response: ' + xhr.responseText);
       onError(fromHttpStatus(xhr.status));
     }
   };
 
   remoting.xhr.start({
     method: 'POST',
@@ skipping 29 matching lines @@
     if (xhr.status == 200) {
       try {
         // Don't use base.jsonParseSafe here unless you also include base.js,
         // otherwise this won't work from the OAuth trampoline.
         // TODO(jamiewalch): Fix this once we're no longer using the trampoline.
         var tokens = JSON.parse(xhr.responseText);
         onDone(tokens['refresh_token'],
                tokens['access_token'], tokens['expires_in']);
       } catch (/** @type {Error} */ err) {
         console.error('Invalid "token" response from server:', err);
-        onError(remoting.Error.UNEXPECTED);
+        onError(remoting.Error.unexpected());
       }
     } else {
       console.error('Failed to exchange code for token. Status: ' + xhr.status +
                     ' response: ' + xhr.responseText);
       onError(fromHttpStatus(xhr.status));
     }
   };
 
   remoting.xhr.start({
     method: 'POST',
@@ skipping 21 matching lines @@
  */
 remoting.OAuth2ApiImpl.prototype.getEmail = function(onDone, onError, token) {
   /** @param {XMLHttpRequest} xhr */
   var onResponse = function(xhr) {
     if (xhr.status == 200) {
       try {
         var result = JSON.parse(xhr.responseText);
         onDone(result['email']);
       } catch (/** @type {Error} */ err) {
         console.error('Invalid "userinfo" response from server:', err);
-        onError(remoting.Error.UNEXPECTED);
+        onError(remoting.Error.unexpected());
       }
     } else {
       console.error('Failed to get email. Status: ' + xhr.status +
                     ' response: ' + xhr.responseText);
       onError(fromHttpStatus(xhr.status));
     }
   };
   remoting.xhr.start({
     method: 'GET',
     url: this.getOAuth2ApiUserInfoEndpoint_(),
@@ skipping 15 matching lines @@
 remoting.OAuth2ApiImpl.prototype.getUserInfo =
     function(onDone, onError, token) {
   /** @param {XMLHttpRequest} xhr */
   var onResponse = function(xhr) {
     if (xhr.status == 200) {
       try {
         var result = JSON.parse(xhr.responseText);
         onDone(result['email'], result['name']);
       } catch (/** @type {Error} */ err) {
         console.error('Invalid "userinfo" response from server:', err);
-        onError(remoting.Error.UNEXPECTED);
+        onError(remoting.Error.unexpected());
       }
     } else {
       console.error('Failed to get user info. Status: ' + xhr.status +
                     ' response: ' + xhr.responseText);
       onError(fromHttpStatus(xhr.status));
     }
   };
   remoting.xhr.start({
     method: 'GET',
     url: this.getOAuth2ApiUserInfoEndpoint_(),
     onDone: onResponse,
     oauthToken: token
   });
 };
 
 /** @returns {!remoting.Error} */
 function fromHttpStatus(/** number */ status) {
   var error = remoting.Error.fromHttpStatus(status);
-  if (error === remoting.Error.UNEXPECTED) {
+  if (error === remoting.Error.unexpected()) {
     // Return AUTHENTICATION_FAILED by default, so that the user can try to
     // recover from an unexpected failure by signing in again.
-    return remoting.Error.AUTHENTICATION_FAILED;
+    return new remoting.Error(remoting.Error.Tag.AUTHENTICATION_FAILED);
   }
   return error;
 }
 
 /** @type {remoting.OAuth2Api} */
 remoting.oauth2Api = new remoting.OAuth2ApiImpl();
 
 })();