Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: tools/perf/measurements/rasterize_and_record.py

Issue 100443007: telemetry: handle tests that are not supported on a platform. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and fixes for run_benchmark case. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/rasterize_and_record.py
diff --git a/tools/perf/measurements/rasterize_and_record.py b/tools/perf/measurements/rasterize_and_record.py
index 5e4bd75e2536edfa231be664ba21f8cf1cf96a33..07411edc83038209d4c3de2faeb8727c7e19482c 100644
--- a/tools/perf/measurements/rasterize_and_record.py
+++ b/tools/perf/measurements/rasterize_and_record.py
@@ -2,11 +2,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import logging
import time
from metrics import rendering_stats
from telemetry.page import page_measurement
+from telemetry.page import page_test
from telemetry.page.perf_tests_helper import FlattenList
import telemetry.core.timeline.bounds as timeline_bounds
from telemetry.core.timeline.model import TimelineModel
@@ -61,10 +61,11 @@ class RasterizeAndRecord(page_measurement.PageMeasurement):
self._compositing_features_enabled = True
def MeasurePage(self, page, tab, results):
+ # Throw and exception if threaded forced compositing is not enabled.
tonyg 2014/03/14 01:32:49 s/and/an/ Or actually, just delete the comment al
ernstm 2014/03/24 22:27:22 Done.
if not self._compositing_features_enabled:
- logging.warning('Warning: compositing feature status unknown or not '+
- 'forced and threaded. Skipping measurement.')
- return
+ raise page_test.TestNotSupportedOnPlatformFailure(
+ 'Compositing feature status unknown or not '+
+ 'forced and threaded. Skipping measurement.')
# Rasterize only what's visible.
tab.ExecuteJavaScript(
« no previous file with comments | « no previous file | tools/perf/measurements/rasterize_and_record_micro.py » ('j') | tools/telemetry/telemetry/page/page_test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698