Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: tools/telemetry/telemetry/page/page_test_runner.py

Issue 100443007: telemetry: handle tests that are not supported on a platform. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Catch new exception in TestTracingCleanedUp. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | tools/telemetry/telemetry/test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_test_runner.py
diff --git a/tools/telemetry/telemetry/page/page_test_runner.py b/tools/telemetry/telemetry/page/page_test_runner.py
index 369c19e627bb48c9354d2eac050242ac0dcda748..dc11f5fb1c07422b77257580744acae197190540 100644
--- a/tools/telemetry/telemetry/page/page_test_runner.py
+++ b/tools/telemetry/telemetry/page/page_test_runner.py
@@ -1,15 +1,17 @@
# Copyright (c) 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import logging
import os
import sys
from telemetry import test as test_module
from telemetry.core import browser_options
from telemetry.core import discover
-from telemetry.page import page_test as page_test_module
from telemetry.page import page_runner
from telemetry.page import page_set
+from telemetry.page import page_test as page_test_module
+from telemetry.page import page_test_results
def Main(env):
"""Turns a PageTest into a command-line program.
@@ -36,7 +38,11 @@ class PageTestRunner(object):
def Run(self, env):
test, ps, expectations = self.ParseCommandLine(sys.argv, env)
- results = page_runner.Run(test, ps, expectations, self._options)
+ results = page_test_results.PageTestResults()
+ try:
+ results = page_runner.Run(test, ps, expectations, self._options)
+ except page_test_module.TestNotSupportedOnPlatformFailure as failure:
+ logging.warning(str(failure))
results.PrintSummary()
return min(255, len(results.failures + results.errors))
« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | tools/telemetry/telemetry/test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698