Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/perf/measurements/rasterize_and_record.py

Issue 100443007: telemetry: handle tests that are not supported on a platform. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/rasterize_and_record.py
diff --git a/tools/perf/measurements/rasterize_and_record.py b/tools/perf/measurements/rasterize_and_record.py
index 84b4e5e6e5b451f4d4fefd17d84155df0848514b..ffbb3a4d0a870a473dc4217cbe2005b408b60cb0 100644
--- a/tools/perf/measurements/rasterize_and_record.py
+++ b/tools/perf/measurements/rasterize_and_record.py
@@ -2,12 +2,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import logging
-import sys
import time
from metrics import rendering_stats
from telemetry.page import page_measurement
+from telemetry.page import page_test
import telemetry.core.timeline.bounds as timeline_bounds
from telemetry.core.timeline.model import MarkerMismatchError
from telemetry.core.timeline.model import MarkerOverlapError
@@ -60,11 +59,11 @@ class RasterizeAndRecord(page_measurement.PageMeasurement):
self._compositing_features_enabled = True
def MeasurePage(self, page, tab, results):
- # Exit if threaded forced compositing is not enabled.
+ # Throw and exception if threaded forced compositing is not enabled.
if (not self._compositing_features_enabled):
- logging.warning('Warning: compositing feature status unknown or not '+
- 'forced and threaded. Skipping measurement.')
- sys.exit(0)
+ raise page_test.TestNotSupportedOnPlatformFailure(
+ 'Compositing feature status unknown or not '+
+ 'forced and threaded. Skipping measurement.')
# Rasterize only what's visible.
tab.ExecuteJavaScript(

Powered by Google App Engine
This is Rietveld 408576698