Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1004363002: Improve Sky's Scrollable physics (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Improve Sky's Scrollable physics We now use a physics simulationt to drive the scroll fling. We're also closer to integrating fling into overscroll. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eca7844cde8ec0523e8c961f6445efae83ef66ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -40 lines) Patch
M sky/framework/animation/mechanics.dart View 2 chunks +18 lines, -1 line 0 comments Download
M sky/framework/animation/scroll_behavior.dart View 2 chunks +12 lines, -3 lines 0 comments Download
M sky/framework/components/scrollable.dart View 6 chunks +20 lines, -35 lines 0 comments Download
M sky/framework/theme/view-configuration.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-13 22:45:02 UTC) #1
abarth-chromium
5 years, 9 months ago (2015-03-13 22:45:12 UTC) #2
eseidel
lgtm
5 years, 9 months ago (2015-03-13 22:45:44 UTC) #3
abarth-chromium
5 years, 9 months ago (2015-03-13 22:57:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eca7844cde8ec0523e8c961f6445efae83ef66ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698