pkg/analysis_server/test/services/completion/invocation_computer_test.dart - Issue 1004343002: Completion should not show overridden inherited methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/invocation_computer_test.dart

Issue 1004343002: Completion should not show overridden inherited methods (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/completion/imported_computer_test.dart ('k') | pkg/analysis_server/test/services/completion/local_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/invocation_computer_test.dart

diff --git a/pkg/analysis_server/test/services/completion/invocation_computer_test.dart b/pkg/analysis_server/test/services/completion/invocation_computer_test.dart

index 3cd9d6785cad92601e070605c733eec9ddacf6ec..7f4c2091f3895690a813a9e297da44a5af152c49 100644

--- a/pkg/analysis_server/test/services/completion/invocation_computer_test.dart

+++ b/pkg/analysis_server/test/services/completion/invocation_computer_test.dart

@@ -399,7 +399,7 @@ void main() {C.^ print("something");}''');

check_shadowing('int x;', 'set x(int value) {}', true);

test_shadowing_getter_over_field() =>

- check_shadowing('int get x => null;', 'int x;', false);

+ check_shadowing('int get x => null;', 'int x;', true);

test_shadowing_getter_over_getter() =>

check_shadowing('int get x => null;', 'int get x => null;', true);

@@ -408,7 +408,7 @@ void main() {C.^ print("something");}''');

check_shadowing('int get x => null;', 'void x() {}', true);

test_shadowing_getter_over_setter() =>

- check_shadowing('int get x => null;', 'set x(int value) {}', false);

+ check_shadowing('int get x => null;', 'set x(int value) {}', true);

test_shadowing_method_over_field() =>

check_shadowing('void x() {}', 'int x;', true);

@@ -468,10 +468,10 @@ void test(Derived d) {

}

test_shadowing_setter_over_field() =>

- check_shadowing('set x(int value) {}', 'int x;', false);

+ check_shadowing('set x(int value) {}', 'int x;', true);

test_shadowing_setter_over_getter() =>

- check_shadowing('set x(int value) {}', 'int get x => null;', false);

+ check_shadowing('set x(int value) {}', 'int get x => null;', true);

test_shadowing_setter_over_method() =>

check_shadowing('set x(int value) {}', 'void x() {}', true);