pkg/analysis_server/test/services/completion/imported_computer_test.dart - Issue 1004343002: Completion should not show overridden inherited methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/imported_computer_test.dart

Issue 1004343002: Completion should not show overridden inherited methods (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/completion/completion_computer_test.dart ('k') | pkg/analysis_server/test/services/completion/invocation_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/imported_computer_test.dart

diff --git a/pkg/analysis_server/test/services/completion/imported_computer_test.dart b/pkg/analysis_server/test/services/completion/imported_computer_test.dart

index 39e7d1a3c2a5f080197e962967e919f0a0e7dc2f..fd323e2b5b9704f1e5d350c582fcd2bfc697589c 100644

--- a/pkg/analysis_server/test/services/completion/imported_computer_test.dart

+++ b/pkg/analysis_server/test/services/completion/imported_computer_test.dart

@@ -593,9 +593,6 @@ class B extends A {

}

test_mixin_ordering() {

- // TODO(paulberry): The mixins are visited in the correct order, so we see

- // M2.m() before M1.m(), as we should. But the second (shadowed) result

- // isn't being thrown out as it should.

addSource('/libA.dart', '''

class B {}

class M1 {