pkg/analysis_server/test/services/completion/completion_computer_test.dart - Issue 1004343002: Completion should not show overridden inherited methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/completion_computer_test.dart

Issue 1004343002: Completion should not show overridden inherited methods (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/domain_completion_test.dart ('k') | pkg/analysis_server/test/services/completion/imported_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_computer_test.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_computer_test.dart b/pkg/analysis_server/test/services/completion/completion_computer_test.dart

index 6536782d9647fb9441ec18e4e384d688866d1569..37afa8f792b50ab20415c07d55ff324918135825 100644

--- a/pkg/analysis_server/test/services/completion/completion_computer_test.dart

+++ b/pkg/analysis_server/test/services/completion/completion_computer_test.dart

@@ -181,7 +181,7 @@ class MockCompletionComputer extends DartCompletionComputer {

this.request = request;

fastCount++;

if (fastSuggestion != null) {

- request.suggestions.add(fastSuggestion);

+ request.addSuggestion(fastSuggestion);

}

return fastSuggestion != null;

}

@@ -191,7 +191,7 @@ class MockCompletionComputer extends DartCompletionComputer {

this.request = request;

fullCount++;

if (fullSuggestion != null) {

- request.suggestions.add(fullSuggestion);

+ request.addSuggestion(fullSuggestion);

}

return new Future.value(fullSuggestion != null);

}