Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

Issue 1004343002: Completion should not show overridden inherited methods (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
index c226403d43be9fb468d0f489cd6c779b52c47648..e8824744485cf14aa2c299aef812384c8c735db0 100644
--- a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
+++ b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
@@ -165,11 +165,6 @@ void visitInheritedTypes(ClassDeclaration node,
abstract class ElementSuggestionBuilder {
/**
- * Internal collection of completions to prevent duplicate completions.
- */
- final Set<String> _completions = new Set<String>();
-
- /**
* Return the kind of suggestions that should be built.
*/
CompletionSuggestionKind get kind;
@@ -196,15 +191,13 @@ abstract class ElementSuggestionBuilder {
}
}
String completion = element.displayName;
- if (completion == null ||
- completion.length <= 0 ||
- !_completions.add(completion)) {
+ if (completion == null || completion.length <= 0) {
return;
}
CompletionSuggestion suggestion =
createSuggestion(element, kind: kind, relevance: relevance);
if (suggestion != null) {
- request.suggestions.add(suggestion);
+ request.addSuggestion(suggestion);
}
}
}
@@ -307,7 +300,7 @@ class InterfaceTypeSuggestionBuilder {
}
CompletionSuggestion suggestion = createSuggestion(element, kind: kind);
if (suggestion != null) {
- request.suggestions.add(suggestion);
+ request.addSuggestion(suggestion);
}
}

Powered by Google App Engine
This is Rietveld 408576698