Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: pkg/analysis_server/lib/src/services/completion/local_computer.dart

Issue 1004343002: Completion should not show overridden inherited methods (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/local_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/local_computer.dart b/pkg/analysis_server/lib/src/services/completion/local_computer.dart
index 243d01207d4cd8c6a2b8b512d57e6e6a6c0ff8b6..028b11660757bb96077fd800ae5434aa3719cf78 100644
--- a/pkg/analysis_server/lib/src/services/completion/local_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/local_computer.dart
@@ -5,7 +5,6 @@
library services.completion.computer.dart.local;
import 'dart:async';
-import 'dart:collection';
import 'package:analysis_server/src/protocol.dart' as protocol
show Element, ElementKind;
@@ -273,7 +272,7 @@ class _ConstructorVisitor extends LocalDeclarationVisitor {
parameterTypes: parameterTypes,
requiredParameterCount: requiredParameterCount,
hasNamedParameters: hasNamedParameters);
- request.suggestions.add(suggestion);
+ request.addSuggestion(suggestion);
return suggestion;
}
@@ -403,7 +402,7 @@ class _LabelVisitor extends LocalDeclarationVisitor {
CompletionSuggestion suggestion = new CompletionSuggestion(
CompletionSuggestionKind.IDENTIFIER, DART_RELEVANCE_DEFAULT,
completion, completion.length, 0, false, false);
- request.suggestions.add(suggestion);
+ request.addSuggestion(suggestion);
return suggestion;
}
}
@@ -429,7 +428,6 @@ class _LabelVisitor extends LocalDeclarationVisitor {
class _LocalVisitor extends LocalDeclarationVisitor {
final DartCompletionRequest request;
final OpType optype;
- HashSet<String> completions = new HashSet();
_LocalVisitor(this.request, int offset, this.optype) : super(offset);
@@ -668,10 +666,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {
bool isDeprecated, int defaultRelevance, {ClassDeclaration classDecl}) {
if (id != null) {
String completion = id.name;
- if (completion != null &&
- completion.length > 0 &&
- completion != '_' &&
- completions.add(completion)) {
+ if (completion != null && completion.length > 0 && completion != '_') {
CompletionSuggestion suggestion = new CompletionSuggestion(
CompletionSuggestionKind.INVOCATION,
isDeprecated ? DART_RELEVANCE_LOW : defaultRelevance, completion,
@@ -686,7 +681,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {
}
}
}
- request.suggestions.add(suggestion);
+ request.addSuggestion(suggestion);
return suggestion;
}
}

Powered by Google App Engine
This is Rietveld 408576698