pkg/analysis_server/lib/src/services/completion/keyword_computer.dart - Issue 1004343002: Completion should not show overridden inherited methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

Issue 1004343002: Completion should not show overridden inherited methods (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/imported_computer.dart ('k') | pkg/analysis_server/lib/src/services/completion/local_computer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart b/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

index db65d77962f9ce101cd7f17231b2a10f806b3495..36d403b4ca6886c3eb967345e1d6b71c1f8f5760 100644

--- a/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

+++ b/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

@@ -219,7 +219,7 @@ class _KeywordVisitor extends GeneralizingAstVisitor {

void _addSuggestion(Keyword keyword,

[int relevance = DART_RELEVANCE_DEFAULT]) {

String completion = keyword.syntax;

- request.suggestions.add(new CompletionSuggestion(

+ request.addSuggestion(new CompletionSuggestion(

CompletionSuggestionKind.KEYWORD,

relevance, completion, completion.length, 0, false, false));

}