[chromedriver] Add a sanity check during session initiation

[chromedriver] Add a sanity check during session initiation

BUG=chromedriver:1058
Committed: https://crrev.com/3aa113195dea4d4fcd20686d4414abb97c75f72a
Cr-Commit-Position: refs/heads/master@{#320661}

[samuong, 2015-03-13 20:37:48]

samuong@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2015-03-14 00:22:04]

lgtm

My comments are optional.

https://codereview.chromium.org/1004333002/diff/1/chrome/test/chromedriver/se...
File chrome/test/chromedriver/session_commands.cc (right):

https://codereview.chromium.org/1004333002/diff/1/chrome/test/chromedriver/se...
chrome/test/chromedriver/session_commands.cc:123: "function(s){return
s.replace('i','o')}",
For the purpose of sanity check, maybe a simple "return '1';" is good enough?

https://codereview.chromium.org/1004333002/diff/1/chrome/test/chromedriver/se...
chrome/test/chromedriver/session_commands.cc:131: base::StringPrintf("unexpected
response from browser"));
It seems other places use raw strings directly, like line 146 and 189 below. Is
there a special reason to use base::StringPrintf?

[samuong, 2015-03-14 17:17:46]

https://codereview.chromium.org/1004333002/diff/1/chrome/test/chromedriver/se...
File chrome/test/chromedriver/session_commands.cc (right):

https://codereview.chromium.org/1004333002/diff/1/chrome/test/chromedriver/se...
chrome/test/chromedriver/session_commands.cc:123: "function(s){return
s.replace('i','o')}",
On 2015/03/14 00:22:03, Shuotao wrote:
> For the purpose of sanity check, maybe a simple "return '1';" is good enough?

Done.

https://codereview.chromium.org/1004333002/diff/1/chrome/test/chromedriver/se...
chrome/test/chromedriver/session_commands.cc:131: base::StringPrintf("unexpected
response from browser"));
On 2015/03/14 00:22:03, Shuotao wrote:
> It seems other places use raw strings directly, like line 146 and 189 below.
Is
> there a special reason to use base::StringPrintf?

Done. It's no longer needed, so I've removed it.

[samuong, 2015-03-14 17:17:49]

The CQ bit was checked by samuong@chromium.org

[samuong, 2015-03-14 17:17:50]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/1004333002/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2015-03-14 17:17:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1004333002/20001

[commit-bot: I haz the power, 2015-03-14 17:47:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-14 17:48:52]

Patchset 2 (id:??) landed as
https://crrev.com/3aa113195dea4d4fcd20686d4414abb97c75f72a
Cr-Commit-Position: refs/heads/master@{#320661}