Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: Tools/DumpRenderTree/chromium/DumpRenderTree.cpp

Issue 100433005: [oilpan] Rename PauseScope to SafePointScope (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/heap/ThreadState.cpp ('K') | « Source/oilpan-chromium.patch ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
diff --git a/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp b/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
index aa2356eac90357b44ae0cc6ca145be36d7967bc6..22ed8d7e36a75a50b41f44f16d130ceb7a316540 100644
--- a/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
+++ b/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
@@ -125,9 +125,11 @@ static void runTest(TestShell& shell, TestParams& params, const string& inputLin
}
shell.setLayoutTestTimeout(oldTimeoutMsec);
- // FIXME(oilpan): we mark thread as paused after each task completion (see HandleScopeManager). This causes us to arrive here in a paused state which is wrong.
- // Need a better integration of the main thread event loop with the ThreadState, but it is outside of WebKit. So for now just forcefully reset paused state.
- WebCore::ThreadState::Current()->resumed();
+ // FIXME(oilpan): Enter thread in safe point after each task completion.
+ // This causes us to arrive here in a paused state which is wrong.
+ // Need a better integration of the main thread event loop with the ThreadState,
+ // but it is outside of WebKit. So for now just forcefully leave safe point.
+ WebCore::ThreadState::Current()->leaveSafePoint();
shell.callJSGC();
if (WebCore::RuntimeEnabledFeatures::timeMeasurementEnabled())
fprintf(stderr, "RecalcStyle = %lf ms\n", recalcStyleStat.accumulated());
« Source/heap/ThreadState.cpp ('K') | « Source/oilpan-chromium.patch ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698