[oilpan] Rename PauseScope to SafePointScope

[oilpan] Rename PauseScope to SafePointScope

This name is consistent with ThreadState::safePoint().

R=ager@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163245

[haraken, 2013-12-05 02:37:56]

PTAL

[Mads Ager (chromium), 2013-12-05 08:39:41]

https://codereview.chromium.org/100433005/diff/20001/Source/heap/ThreadState.h
File Source/heap/ThreadState.h (right):

https://codereview.chromium.org/100433005/diff/20001/Source/heap/ThreadState....
Source/heap/ThreadState.h:239: SafePointScope(StackState stackState) {
ThreadState::Current()->paused(stackState); }
As discussed offline we should change the names of paused/resumed to
enterSafePoint/leaveSafePoint.

[haraken, 2013-12-05 08:43:04]

On 2013/12/05 08:39:41, Mads Ager (chromium) wrote:
> https://codereview.chromium.org/100433005/diff/20001/Source/heap/ThreadState.h
> File Source/heap/ThreadState.h (right):
> 
>
https://codereview.chromium.org/100433005/diff/20001/Source/heap/ThreadState....
> Source/heap/ThreadState.h:239: SafePointScope(StackState stackState) {
> ThreadState::Current()->paused(stackState); }
> As discussed offline we should change the names of paused/resumed to
> enterSafePoint/leaveSafePoint.

Will do.

Just to be clear: We prefer "SafePoint" to "GCSafePoint", right? (If we want to
make it more self-descriptive as Erik mentioned, "GCSafePoint" might be better.
BTW, 5 people around me didn't know safe points:-)

[Mads Ager (chromium), 2013-12-05 08:46:19]

On 2013/12/05 08:43:04, haraken wrote:
> On 2013/12/05 08:39:41, Mads Ager (chromium) wrote:
> >
https://codereview.chromium.org/100433005/diff/20001/Source/heap/ThreadState.h
> > File Source/heap/ThreadState.h (right):
> > 
> >
>
https://codereview.chromium.org/100433005/diff/20001/Source/heap/ThreadState....
> > Source/heap/ThreadState.h:239: SafePointScope(StackState stackState) {
> > ThreadState::Current()->paused(stackState); }
> > As discussed offline we should change the names of paused/resumed to
> > enterSafePoint/leaveSafePoint.
> 
> Will do.
> 
> Just to be clear: We prefer "SafePoint" to "GCSafePoint", right? (If we want
to
> make it more self-descriptive as Erik mentioned, "GCSafePoint" might be
better.

I prefer just SafePoint. Let's go for that for now.

> BTW, 5 people around me didn't know safe points:-)

I'm not surprised if they haven't worked on GCs before. However, if you have
worked on a garbage collector this is very well-established terminology. Have a
look at the results of a Google search form "garbage collection safepoint". :-)

[haraken, 2013-12-05 09:17:25]

Uploaded. PTAL.

[Mads Ager (chromium), 2013-12-05 09:22:24]

LGTM

https://codereview.chromium.org/100433005/diff/40001/Source/WebKit/chromium/s...
File Source/WebKit/chromium/src/WebKit.cpp (right):

https://codereview.chromium.org/100433005/diff/40001/Source/WebKit/chromium/s...
Source/WebKit/chromium/src/WebKit.cpp:97: if (!m_nesting &&
WebCore::ThreadState::MainThreadState()->isInSafePoint())
isAtSafePoint?

https://codereview.chromium.org/100433005/diff/40001/Source/heap/ThreadState.cpp
File Source/heap/ThreadState.cpp (right):

https://codereview.chromium.org/100433005/diff/40001/Source/heap/ThreadState....
Source/heap/ThreadState.cpp:76: // Request other attached and not-in-safe-point
threads to park themselves on safepoints.
Request other attached threads that are not at safe points to park themselves?

https://codereview.chromium.org/100433005/diff/40001/Source/heap/ThreadState....
Source/heap/ThreadState.cpp:450: bool wasInSafePoint = false;
wasAtSafePoint?

https://codereview.chromium.org/100433005/diff/40001/Source/heap/ThreadState.h
File Source/heap/ThreadState.h (right):

https://codereview.chromium.org/100433005/diff/40001/Source/heap/ThreadState....
Source/heap/ThreadState.h:289: bool m_inSafePoint;
m_atSafePoint?

[haraken, 2013-12-05 09:37:40]

https://codereview.chromium.org/100433005/diff/40001/Source/WebKit/chromium/s...
File Source/WebKit/chromium/src/WebKit.cpp (right):

https://codereview.chromium.org/100433005/diff/40001/Source/WebKit/chromium/s...
Source/WebKit/chromium/src/WebKit.cpp:97: if (!m_nesting &&
WebCore::ThreadState::MainThreadState()->isInSafePoint())
On 2013/12/05 09:22:24, Mads Ager (chromium) wrote:
> isAtSafePoint?

Done. (I called it inSafePoint since we have ThreadState::isInGC and
ThreadState::m_inGC, and "safe point" sounds like some space to be
entered/left.)

https://codereview.chromium.org/100433005/diff/40001/Source/heap/ThreadState.cpp
File Source/heap/ThreadState.cpp (right):

https://codereview.chromium.org/100433005/diff/40001/Source/heap/ThreadState....
Source/heap/ThreadState.cpp:76: // Request other attached and not-in-safe-point
threads to park themselves on safepoints.
On 2013/12/05 09:22:24, Mads Ager (chromium) wrote:
> Request other attached threads that are not at safe points to park themselves?

Done.

[haraken, 2013-12-05 09:39:26]

Committed patchset #4 manually as r163245.