Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5066)

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 1004323003: Add support for sending protobuf messages over IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zip
Patch Set: remove todo and enable for cros Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index 21b25630511f470bfb02bc9fc01aa15ff17ba729..cd8d4bd9611d351de0c831f666c5a78a3d87f0b1 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -1040,6 +1040,8 @@
'browser/safe_browsing/safe_browsing_store_unittest.cc',
'browser/safe_browsing/safe_browsing_util_unittest.cc',
'browser/safe_browsing/two_phase_uploader_unittest.cc',
+ 'common/safe_browsing/ipc_protobuf_message_test_messages.h',
+ 'common/safe_browsing/ipc_protobuf_message_unittest.cc',
'renderer/safe_browsing/features_unittest.cc',
'renderer/safe_browsing/murmurhash3_util_unittest.cc',
'renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc',
@@ -2297,6 +2299,9 @@
# TODO(sgurun): enable tests for safe_browsing==2.
'sources': [ '<@(chrome_unit_tests_full_safe_browsing_sources)' ],
'defines': [ 'FULL_SAFE_BROWSING' ],
+ 'dependencies': [
+ 'ipc_protobuf_message_test_proto',
+ ],
'conditions': [
['chromeos == 1', {
'sources!': [
@@ -2304,12 +2309,17 @@
],
}],
['OS == "android"', {
+ 'dependencies!': [
+ 'ipc_protobuf_message_test_proto',
+ ],
'sources!': [
# Android doesn't support download feedbacks.
'browser/safe_browsing/download_feedback_service_unittest.cc',
'browser/safe_browsing/download_feedback_unittest.cc',
'browser/safe_browsing/download_protection_service_unittest.cc',
'browser/safe_browsing/two_phase_uploader_unittest.cc',
+ 'common/safe_browsing/ipc_protobuf_message_test_messages.h',
+ 'common/safe_browsing/ipc_protobuf_message_unittest.cc',
],
}],
],
@@ -2665,6 +2675,21 @@
}],
],
},
+ {
+ # Protobuf compiler / generator for IPC protobuf message tests.
+
+ # GN version: //chrome/test:test_proto
+ 'target_name': 'ipc_protobuf_message_test_proto',
+ 'type': 'static_library',
+ 'sources': [
+ 'common/safe_browsing/ipc_protobuf_message_test.proto'
+ ],
+ 'variables': {
+ 'proto_in_dir': 'common/safe_browsing',
+ 'proto_out_dir': 'chrome/common/safe_browsing',
+ },
+ 'includes': [ '../build/protoc.gypi' ],
+ },
],
'conditions': [

Powered by Google App Engine
This is Rietveld 408576698