Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1004313002: check for null-pixelref (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/images/SkImageDecoder.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004313002/1
5 years, 9 months ago (2015-03-13 19:55:04 UTC) #2
reed1
I think this fixes the crash, but how the heck did the imagedecoder return true, ...
5 years, 9 months ago (2015-03-13 19:56:02 UTC) #5
scroggo
On 2015/03/13 19:56:02, reed1 wrote: > I think this fixes the crash, but how the ...
5 years, 9 months ago (2015-03-13 21:46:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004313002/1
5 years, 9 months ago (2015-03-16 14:21:48 UTC) #8
reed1
Lets update the dox for decoders that Empty is a valid return state for the ...
5 years, 9 months ago (2015-03-16 14:22:11 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 14:28:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dedc2d8e8dc635ff43e6b314b280e3efe85ce8a7

Powered by Google App Engine
This is Rietveld 408576698