Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: extensions/browser/api/execute_code_function.h

Issue 1004253002: Enable <webview>.executeScript outside of Apps and Extensions [2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/execute_code_function.h
diff --git a/extensions/browser/api/execute_code_function.h b/extensions/browser/api/execute_code_function.h
index db0f441c8149baa5391e216057478f1b77181a7b..3dd862b129db4d4bfac9051e2e8ee05273542c8f 100644
--- a/extensions/browser/api/execute_code_function.h
+++ b/extensions/browser/api/execute_code_function.h
@@ -37,14 +37,21 @@ class ExecuteCodeFunction : public AsyncExtensionFunction {
const GURL& on_url,
const base::ListValue& result);
- // The injection details.
- scoped_ptr<core_api::extension_types::InjectDetails> details_;
+ virtual bool LoadFile(const std::string& file);
+
+ // Called when contents from the loaded file have been localized.
+ void DidLoadAndLocalizeFile(const std::string& file,
+ bool success,
+ const std::string& data);
const HostID& host_id() const { return host_id_; }
void set_host_id(HostID host_id) {
host_id_ = host_id;
}
+ // The injection details.
+ scoped_ptr<core_api::extension_types::InjectDetails> details_;
+
private:
// Called when contents from the file whose path is specified in JSON
// arguments has been loaded.
@@ -58,9 +65,6 @@ class ExecuteCodeFunction : public AsyncExtensionFunction {
const base::FilePath& extension_path,
const std::string& extension_default_locale);
- // Called when contents from the loaded file have been localized.
- void DidLoadAndLocalizeFile(bool success, const std::string& data);
-
// Run in UI thread. Code string contains the code to be executed. Returns
// true on success. If true is returned, this does an AddRef.
bool Execute(const std::string& code_string);
« no previous file with comments | « chrome/test/data/webui/webview_execute_script_test.js ('k') | extensions/browser/api/execute_code_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698