extensions/browser/api/guest_view/web_view/web_view_internal_api.h - Issue 1004253002: Enable <webview>.executeScript outside of Apps and Extensions [2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/guest_view/web_view/web_view_internal_api.h

Issue 1004253002: Enable <webview>.executeScript outside of Apps and Extensions [2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/execute_code_function.cc ('K') | « extensions/browser/api/execute_code_function.cc ('k') | extensions/browser/api/guest_view/web_view/web_view_internal_api.cc » ('j') | extensions/browser/api/guest_view/web_view/web_view_internal_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/guest_view/web_view/web_view_internal_api.h

diff --git a/extensions/browser/api/guest_view/web_view/web_view_internal_api.h b/extensions/browser/api/guest_view/web_view/web_view_internal_api.h

index 37483df9e0a1c09c9b74057999f9cb005b590faa..b106c8a058df917611a70fa7c9ddfd127ef76da2 100644

--- a/extensions/browser/api/guest_view/web_view/web_view_internal_api.h

+++ b/extensions/browser/api/guest_view/web_view/web_view_internal_api.h

@@ -66,8 +66,15 @@ class WebViewInternalExecuteCodeFunction

extensions::ScriptExecutor* GetScriptExecutor() final;

bool IsWebView() const override;

const GURL& GetWebViewSrc() const override;

+ bool LoadFileForWebUI(const std::string& file_src,

+ const WebUILoadFileCallback& callback) override;

private:

+ class WebUIURLFetcher;

+ // Callbacks from WebUIURLFetcher.

+ void OnWebUIURLFetchComplete(const WebUIURLFetcher* fetcher);

// Contains extension resource built from path of file which is

// specified in JSON arguments.

extensions::ExtensionResource resource_;

@@ -76,6 +83,8 @@ class WebViewInternalExecuteCodeFunction

GURL guest_src_;

+ ScopedVector<WebUIURLFetcher> fetchers_;

DISALLOW_COPY_AND_ASSIGN(WebViewInternalExecuteCodeFunction);

};