chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 1004253002: Enable <webview>.executeScript outside of Apps and Extensions [2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 1004253002: Enable <webview>.executeScript outside of Apps and Extensions [2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.h ('k') | extensions/browser/api/execute_code_function.h » ('j') | extensions/browser/api/execute_code_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 229d89aaed2445c1b428504800768e261b4dedac..00be6c9431a756ff3fd1886b3b52f81fd28e6a4b 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -1799,6 +1799,13 @@ const GURL& ExecuteCodeInTabFunction::GetWebViewSrc() const {

return GURL::EmptyGURL();

}

+bool ExecuteCodeInTabFunction::LoadFileForWebUI(

Fady Samuel 2015/03/14 04:26:56 Make this code the default implementation in Execu

Xi Han 2015/03/16 14:36:05 Done.

+ const std::string& file_src,

+ const WebUILoadFileCallback& callback) {

+ callback.Run(false, std::string());

+ return false;

bool TabsExecuteScriptFunction::ShouldInsertCSS() const {

return false;

}