Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1004233002: Moved the contextmenu webview API to stable, and removed the experimental API infrastructure. (Closed)

Created:
5 years, 9 months ago by paulmeyer
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved the contextmenu webview API to stable, and removed the experimental API infrastructure. BUG=466884 TBR=sky@chromium.org for renderer_resources.grd Committed: https://crrev.com/090e2fbd16ab41dd38d122d5fd184b2039fce105 Cr-Commit-Position: refs/heads/master@{#320731}

Patch Set 1 #

Patch Set 2 : Rebased. #

Messages

Total messages: 15 (6 generated)
paulmeyer
+fsamuel@
5 years, 9 months ago (2015-03-13 16:56:41 UTC) #2
Fady Samuel
Horray for code cleanup! lgtm
5 years, 9 months ago (2015-03-13 16:59:41 UTC) #3
paulmeyer
+kalman@ for non-*web_view*
5 years, 9 months ago (2015-03-13 17:04:57 UTC) #5
not at google - send to devlin
yay lgtm
5 years, 9 months ago (2015-03-13 17:13:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004233002/1
5 years, 9 months ago (2015-03-14 04:27:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/49758)
5 years, 9 months ago (2015-03-14 04:44:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004233002/20001
5 years, 9 months ago (2015-03-16 14:26:35 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 15:54:44 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 15:55:15 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/090e2fbd16ab41dd38d122d5fd184b2039fce105
Cr-Commit-Position: refs/heads/master@{#320731}

Powered by Google App Engine
This is Rietveld 408576698