Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: components/dom_distiller/core/distiller_page.h

Issue 1004223002: Pass more information by argument to the dom_distiller script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/distiller_page.h
diff --git a/components/dom_distiller/core/distiller_page.h b/components/dom_distiller/core/distiller_page.h
index 74cf277935b81809bb979aae01e37bac2aa2a2d0..b78a68e341c2f2d388598c74828beb696089ba7d 100644
--- a/components/dom_distiller/core/distiller_page.h
+++ b/components/dom_distiller/core/distiller_page.h
@@ -55,6 +55,14 @@ class DistillerPage {
// should be the same regardless of the DistillerPage implementation.
virtual void DistillPageImpl(const GURL& url, const std::string& script) = 0;
+ // The value returned between the javascript and the DistillerPage can be
nyquist 2015/03/16 20:39:03 Nit: JavaScript here and below.
noyau (Ping after 24h) 2015/03/17 10:35:39 Done.
+ // either a dictionary with all the content, or a stringified version.
+ virtual bool StringifyOutput() = 0;
+
+ // If true, forces the creation of a new window context to evaluate the
+ // javascript.
+ virtual bool CreateNewContext() = 0;
+
private:
bool ready_;
DistillerPageCallback distiller_page_callback_;

Powered by Google App Engine
This is Rietveld 408576698