Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1004173004: Make the simple QUIC client able to resolve hosts. (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the simple QUIC client able to resolve hosts. Implement a SynchronousHostResolver for this purpose. Committed: https://crrev.com/acfb2f91085d5291ba1c9a04dbe7aea610b13e33 Cr-Commit-Position: refs/heads/master@{#321688} Committed: https://crrev.com/da78df5aee4e4ebdf62b5b2bc17056ce5db24b61 Cr-Commit-Position: refs/heads/master@{#321708}

Patch Set 1 #

Patch Set 2 : fix old quic_client too #

Patch Set 3 : fix old quic_client too #

Total comments: 4

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : GN #

Patch Set 7 : Add simple_quic_tools as a dep of quic_client #

Patch Set 8 : Remove EXPORT to fix Win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -10 lines) Patch
M net/BUILD.gn View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 3 chunks +12 lines, -5 lines 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 1 2 3 chunks +12 lines, -5 lines 0 comments Download
A net/tools/quic/synchronous_host_resolver.h View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
A net/tools/quic/synchronous_host_resolver.cc View 1 2 3 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
Ryan Hamilton
5 years, 9 months ago (2015-03-20 17:29:03 UTC) #2
ramant (doing other things)
Thanks very much for doing this. LGTM. https://codereview.chromium.org/1004173004/diff/40001/net/tools/quic/synchronous_host_resolver.cc File net/tools/quic/synchronous_host_resolver.cc (right): https://codereview.chromium.org/1004173004/diff/40001/net/tools/quic/synchronous_host_resolver.cc#newcode1 net/tools/quic/synchronous_host_resolver.cc:1: #include "net/tools/quic/synchronous_host_resolver.h" ...
5 years, 9 months ago (2015-03-20 17:46:56 UTC) #3
Ryan Hamilton
Thanks! https://codereview.chromium.org/1004173004/diff/40001/net/tools/quic/synchronous_host_resolver.cc File net/tools/quic/synchronous_host_resolver.cc (right): https://codereview.chromium.org/1004173004/diff/40001/net/tools/quic/synchronous_host_resolver.cc#newcode1 net/tools/quic/synchronous_host_resolver.cc:1: #include "net/tools/quic/synchronous_host_resolver.h" On 2015/03/20 17:46:56, ramant wrote: > ...
5 years, 9 months ago (2015-03-20 21:38:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004173004/80001
5 years, 9 months ago (2015-03-20 21:39:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004173004/100001
5 years, 9 months ago (2015-03-20 21:43:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/71177)
5 years, 9 months ago (2015-03-20 22:00:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004173004/120001
5 years, 9 months ago (2015-03-20 22:42:53 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/38966)
5 years, 9 months ago (2015-03-21 00:39:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004173004/120001
5 years, 9 months ago (2015-03-21 01:47:14 UTC) #20
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 9 months ago (2015-03-21 07:42:16 UTC) #21
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/acfb2f91085d5291ba1c9a04dbe7aea610b13e33 Cr-Commit-Position: refs/heads/master@{#321688}
5 years, 9 months ago (2015-03-21 07:42:53 UTC) #22
pfeldman
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1025133002/ by pfeldman@chromium.org. ...
5 years, 9 months ago (2015-03-21 13:15:13 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004173004/140001
5 years, 9 months ago (2015-03-21 14:13:01 UTC) #26
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 9 months ago (2015-03-22 05:16:47 UTC) #27
commit-bot: I haz the power
5 years, 9 months ago (2015-03-22 05:18:17 UTC) #28
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/da78df5aee4e4ebdf62b5b2bc17056ce5db24b61
Cr-Commit-Position: refs/heads/master@{#321708}

Powered by Google App Engine
This is Rietveld 408576698