chrome/browser/geolocation/geolocation_browsertest.cc - Issue 1004093004: GeolocationBrowserTest: only put bubble in test mode when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_browsertest.cc

Issue 1004093004: GeolocationBrowserTest: only put bubble in test mode when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/geolocation/geolocation_browsertest.cc

diff --git a/chrome/browser/geolocation/geolocation_browsertest.cc b/chrome/browser/geolocation/geolocation_browsertest.cc

index 6e215a0953d604952c9f83459a816073e3dc3874..b32251063a498fbe68b058bcc6710d71a4041fc7 100644

--- a/chrome/browser/geolocation/geolocation_browsertest.cc

+++ b/chrome/browser/geolocation/geolocation_browsertest.cc

@@ -181,7 +181,8 @@ GeolocationNotificationObserver::GeolocationNotificationObserver(

registrar_.Add(this, content::NOTIFICATION_LOAD_STOP,

content::NotificationService::AllSources());

}

- mock_view_->SetBrowserTest(true);

+ if (PermissionBubbleManager::Enabled())

+ mock_view_->SetBrowserTest(true);

}

GeolocationNotificationObserver::~GeolocationNotificationObserver() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »