Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1004093004: GeolocationBrowserTest: only put bubble in test mode when needed (Closed)

Created:
5 years, 9 months ago by felt
Modified:
5 years, 9 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GeolocationBrowserTest: only put bubble in test mode when needed The GeolocationBrowserTest runs both with and without permission bubbles. There's no need to set the permission bubble view into test mode if the permission bubble isn't being used. This adds an if-check. BUG=466714 Committed: https://crrev.com/63bf923a3ef96503219276f9335650e1438f4d28 Cr-Commit-Position: refs/heads/master@{#321552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
felt
tim, ptal?
5 years, 9 months ago (2015-03-19 22:00:02 UTC) #2
timvolodine
lgtm
5 years, 9 months ago (2015-03-20 11:44:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004093004/1
5 years, 9 months ago (2015-03-20 11:48:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 11:51:42 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 11:52:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63bf923a3ef96503219276f9335650e1438f4d28
Cr-Commit-Position: refs/heads/master@{#321552}

Powered by Google App Engine
This is Rietveld 408576698