Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1004093003: Write the predictor state on shutdown on Android. (Closed)

Created:
5 years, 9 months ago by Benoit L
Modified:
5 years, 9 months ago
Reviewers:
nyquist, mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Write the predictor state on shutdown on Android. The predictor usually serializes its state on a clean shutdown, so doesn't on Android. This fixes it. BUG=467007 Committed: https://crrev.com/610bf38c123e85a9c5849d95a7e9c9048004c05d Cr-Commit-Position: refs/heads/master@{#321966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/android/chromium_application.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benoit L
Hello nyquist, mmenke, This is a very small CL adding serialization of the predictor state ...
5 years, 9 months ago (2015-03-16 13:59:48 UTC) #2
nyquist
chrome/browser/android lgtm
5 years, 9 months ago (2015-03-16 20:41:08 UTC) #3
mmenke
On 2015/03/16 20:41:08, nyquist wrote: > chrome/browser/android lgtm I'm sick today, and looking like that ...
5 years, 9 months ago (2015-03-17 18:58:06 UTC) #4
mmenke
LGTM
5 years, 9 months ago (2015-03-20 13:10:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004093003/1
5 years, 9 months ago (2015-03-24 09:19:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 10:46:02 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 10:47:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/610bf38c123e85a9c5849d95a7e9c9048004c05d
Cr-Commit-Position: refs/heads/master@{#321966}

Powered by Google App Engine
This is Rietveld 408576698