Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1004083002: [turbofan] Use builtin inlining mechanism for Math.abs and Math.sqrt. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use builtin inlining mechanism for Math.abs and Math.sqrt. Reduces the amount of custom support code for Math functions in TurboFan and allows for more general inlining (i.e. independent of parameter types). BUG=v8:3952 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/83f157bc18cd9e23f88e045351665c70f283c6ad Cr-Commit-Position: refs/heads/master@{#27172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -104 lines) Patch
M src/compiler/js-builtin-reducer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 6 chunks +10 lines, -9 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-13 05:21:57 UTC) #1
Yang
On 2015/03/13 05:21:57, Benedikt Meurer wrote: lgtm.
5 years, 9 months ago (2015-03-13 07:04:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004083002/1
5 years, 9 months ago (2015-03-13 07:04:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 07:06:08 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 07:06:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83f157bc18cd9e23f88e045351665c70f283c6ad
Cr-Commit-Position: refs/heads/master@{#27172}

Powered by Google App Engine
This is Rietveld 408576698