Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5312)

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.cc

Issue 1004063003: [Extensions] Add logic for when to show the toolbar redesign bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/browser_actions_container.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.cc b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
index 4ea683b2baa7f41a9cfe5b8cd605bc1956f06912..b86b08413c2a0ffa01566426b1bb203f4f2f0ad4 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container.cc
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
@@ -449,7 +449,8 @@ void BrowserActionsContainer::Layout() {
}
void BrowserActionsContainer::OnMouseEntered(const ui::MouseEvent& event) {
- if (!shown_bubble_ && !toolbar_action_views_.empty()) {
+ if (!shown_bubble_ && !toolbar_action_views_.empty() &&
+ toolbar_actions_bar_->ShouldShowInfoBubble()) {
ExtensionToolbarIconSurfacingBubble* bubble =
new ExtensionToolbarIconSurfacingBubble(toolbar_action_views_[0],
toolbar_actions_bar_.get());

Powered by Google App Engine
This is Rietveld 408576698