Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 1003953008: Remove prerender cookie store, part 4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prerender-revert-cookie-store-3
Patch Set: rebase (just in case since this is so huge) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
index 02c67a7456e11ff351ddb03d583ae2d8c554ab1e..0600e9ff28a5669927ebc586c1cd1688b1504f22 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
@@ -239,7 +239,7 @@ TEST_F(ExtensionWebRequestTest, BlockingEventPrecedenceRedirect) {
GURL not_chosen_redirect_url("about:not_chosen");
scoped_ptr<net::URLRequest> request(context_->CreateRequest(
- GURL("about:blank"), net::DEFAULT_PRIORITY, &delegate_, NULL));
+ GURL("about:blank"), net::DEFAULT_PRIORITY, &delegate_));
{
// onBeforeRequest will be dispatched twice initially. The second response -
// the redirect - should win, since it has a later |install_time|. The
@@ -294,7 +294,7 @@ TEST_F(ExtensionWebRequestTest, BlockingEventPrecedenceRedirect) {
// Now test the same thing but the extensions answer in reverse order.
scoped_ptr<net::URLRequest> request2(context_->CreateRequest(
- GURL("about:blank"), net::DEFAULT_PRIORITY, &delegate_, NULL));
+ GURL("about:blank"), net::DEFAULT_PRIORITY, &delegate_));
{
ExtensionWebRequestEventRouter::EventResponse* response = NULL;
@@ -368,7 +368,7 @@ TEST_F(ExtensionWebRequestTest, BlockingEventPrecedenceCancel) {
GURL request_url("about:blank");
scoped_ptr<net::URLRequest> request(context_->CreateRequest(
- request_url, net::DEFAULT_PRIORITY, &delegate_, NULL));
+ request_url, net::DEFAULT_PRIORITY, &delegate_));
// onBeforeRequest will be dispatched twice. The second response -
// the redirect - would win, since it has a later |install_time|, but
@@ -436,7 +436,7 @@ TEST_F(ExtensionWebRequestTest, SimulateChancelWhileBlocked) {
GURL request_url("about:blank");
scoped_ptr<net::URLRequest> request(context_->CreateRequest(
- request_url, net::DEFAULT_PRIORITY, &delegate_, NULL));
+ request_url, net::DEFAULT_PRIORITY, &delegate_));
ExtensionWebRequestEventRouter::EventResponse* response = NULL;
@@ -500,7 +500,7 @@ void ExtensionWebRequestTest::FireURLRequestWithData(
// The request URL can be arbitrary but must have an HTTP or HTTPS scheme.
GURL request_url("http://www.example.com");
scoped_ptr<net::URLRequest> request(context_->CreateRequest(
- request_url, net::DEFAULT_PRIORITY, &delegate_, NULL));
+ request_url, net::DEFAULT_PRIORITY, &delegate_));
request->set_method(method);
if (content_type != NULL) {
request->SetExtraRequestHeaderByName(net::HttpRequestHeaders::kContentType,
@@ -716,7 +716,7 @@ TEST_F(ExtensionWebRequestTest, NoAccessRequestBodyData) {
for (size_t i = 0; i < arraysize(kMethods); ++i) {
scoped_ptr<net::URLRequest> request(context_->CreateRequest(
- request_url, net::DEFAULT_PRIORITY, &delegate_, NULL));
+ request_url, net::DEFAULT_PRIORITY, &delegate_));
request->set_method(kMethods[i]);
ipc_sender_.PushTask(base::Bind(&base::DoNothing));
request->Start();
@@ -837,7 +837,7 @@ TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) {
GURL request_url("http://doesnotexist/does_not_exist.html");
scoped_ptr<net::URLRequest> request(context_->CreateRequest(
- request_url, net::DEFAULT_PRIORITY, &delegate_, NULL));
+ request_url, net::DEFAULT_PRIORITY, &delegate_));
// Initialize headers available before extensions are notified of the
// onBeforeSendHeaders event.

Powered by Google App Engine
This is Rietveld 408576698