Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1003863006: Rollback of merge internal change: 87346681. (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett
Base URL:
https://chromium.googlesource.com/chromium/src.git@Make_SentPacketManager_remove_pending_88507368
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rollback of merge internal change: 87346681. Chromium CL reviewed: https://codereview.chromium.org/968923005/ Chomium committed CL: "Land Recent QUIC Changes until 03/02/2015". https://codereview.chromium.org/968233004/ This CL was in M43 bit not in M42. It impacted last week's Dev release and all Canary released after 03/03/2015. *** Original change description *** Remove TCP and BBR's max congestion window. No practical change, because Chrome's receive window is the limiting factor. Adds kMaxReportedCwnd and kMaxReorderingForRtt as constants to replace the max CWND in classes that used to rely on max CWND. *** Merge internal change: 88545044 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -47 lines) Patch
M net/quic/congestion_control/send_algorithm_interface.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender.cc View 4 chunks +6 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 3 chunks +6 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 5 chunks +22 lines, -14 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 6 chunks +69 lines, -5 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +3 lines, -6 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-16 02:36:06 UTC) #1
Ryan Hamilton
5 years, 9 months ago (2015-03-16 03:17:34 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698