Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Side by Side Diff: chrome/chrome_tests.gypi

Issue 1003853005: Remove Chrome OS-only sources only if the OS is Chrome OS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | chrome/chrome_tests_unit.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 'chrome_browser_extensions_test_support_sources': [ 6 'chrome_browser_extensions_test_support_sources': [
7 # A list of sources which is shared between different browser tests. 7 # A list of sources which is shared between different browser tests.
8 'browser/apps/app_browsertest_util.cc', 8 'browser/apps/app_browsertest_util.cc',
9 'browser/apps/app_browsertest_util.h', 9 'browser/apps/app_browsertest_util.h',
10 'browser/extensions/browsertest_util.cc', 10 'browser/extensions/browsertest_util.cc',
(...skipping 2118 matching lines...) Expand 10 before | Expand all | Expand 10 after
2129 'dependencies': [ 2129 'dependencies': [
2130 '../ash/ash.gyp:ash_test_support', 2130 '../ash/ash.gyp:ash_test_support',
2131 ], 2131 ],
2132 }], 2132 }],
2133 ['use_aura==1 or toolkit_views==1', { 2133 ['use_aura==1 or toolkit_views==1', {
2134 'dependencies': [ 2134 'dependencies': [
2135 '../ui/events/events.gyp:events_test_support', 2135 '../ui/events/events.gyp:events_test_support',
2136 ], 2136 ],
2137 }], 2137 }],
2138 ['chromeos == 1', { 2138 ['chromeos == 1', {
2139 'sources': [ '<@(chrome_browser_tests_chromeos_sources)' ], 2139 'sources': [ '<@(chrome_browser_tests_chromeos_sources)' ],
wtc 2015/03/13 00:42:54 This 'chromeos == 1' section is an appropriate pla
2140 'sources!': [ 2140 'sources!': [
2141 '../apps/load_and_launch_browsertest.cc', 2141 '../apps/load_and_launch_browsertest.cc',
2142 'browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc ', 2142 'browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc ',
2143 'browser/printing/cloud_print/test/cloud_print_proxy_process_browser test.cc', 2143 'browser/printing/cloud_print/test/cloud_print_proxy_process_browser test.cc',
2144 # chromeos does not support profile list avatar menu 2144 # chromeos does not support profile list avatar menu
2145 'browser/profiles/profile_list_desktop_browsertest.cc', 2145 'browser/profiles/profile_list_desktop_browsertest.cc',
2146 'browser/service_process/service_process_control_browsertest.cc', 2146 'browser/service_process/service_process_control_browsertest.cc',
2147 'browser/signin/signin_browsertest.cc', 2147 'browser/signin/signin_browsertest.cc',
2148 # bookmark sign in promo not used on chromeos 2148 # bookmark sign in promo not used on chromeos
2149 'browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.c c', 2149 'browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.c c',
2150 # chromeos does not use cross-platform panels 2150 # chromeos does not use cross-platform panels
2151 'browser/ui/panels/panel_extension_browsertest.cc', 2151 'browser/ui/panels/panel_extension_browsertest.cc',
2152 # chromeos does not use the desktop user manager 2152 # chromeos does not use the desktop user manager
2153 'browser/ui/webui/signin/user_manager_ui_browsertest.cc', 2153 'browser/ui/webui/signin/user_manager_ui_browsertest.cc',
2154 ], 2154 ],
2155 'dependencies': [ 2155 'dependencies': [
2156 '../dbus/dbus.gyp:dbus_test_support', 2156 '../dbus/dbus.gyp:dbus_test_support',
2157 '../build/linux/system.gyp:dbus', 2157 '../build/linux/system.gyp:dbus',
2158 '../ui/login/login.gyp:login_resources', 2158 '../ui/login/login.gyp:login_resources',
2159 ], 2159 ],
2160 'conditions': [
2161 ['use_ozone==1', {
2162 'sources!': [
2163 # crbug.com/362698
wtc 2015/03/13 14:09:58 Since bug 362698 has been fixed, perhaps we can ru
kpschoedel 2015/03/13 15:39:57 Yes, good catch.
wtc 2015/03/13 17:43:55 Thanks for confirming. I re-enabled those two test
2164 'browser/chromeos/input_method/input_method_engine_browsertests. cc',
2165 'browser/extensions/api/input_ime/input_ime_apitest_chromeos.cc' ,
2166 ],
2167 }],
2168 ],
2160 }, { # Non-ChromeOS 2169 }, { # Non-ChromeOS
2161 'sources!': [ 2170 'sources!': [
2162 'browser/extensions/api/enterprise_platform_keys/enterprise_platform _keys_apitest_nss.cc', 2171 'browser/extensions/api/enterprise_platform_keys/enterprise_platform _keys_apitest_nss.cc',
2163 'browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc', 2172 'browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc',
2164 'browser/extensions/api/terminal/terminal_private_apitest.cc', 2173 'browser/extensions/api/terminal/terminal_private_apitest.cc',
2165 'browser/invalidation/profile_invalidation_provider_factory_browsert est.cc', 2174 'browser/invalidation/profile_invalidation_provider_factory_browsert est.cc',
2166 'browser/net/nss_context_chromeos_browsertest.cc', 2175 'browser/net/nss_context_chromeos_browsertest.cc',
2167 'browser/ui/ash/keyboard_controller_browsertest.cc', 2176 'browser/ui/ash/keyboard_controller_browsertest.cc',
2168 'browser/ui/views/select_file_dialog_extension_browsertest.cc', 2177 'browser/ui/views/select_file_dialog_extension_browsertest.cc',
2169 'test/data/webui/certificate_viewer_dialog_test.js', 2178 'test/data/webui/certificate_viewer_dialog_test.js',
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
2403 'renderer/safe_browsing/phishing_classifier_browsertest.cc', 2412 'renderer/safe_browsing/phishing_classifier_browsertest.cc',
2404 'renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc' , 2413 'renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc' ,
2405 'renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.c c', 2414 'renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.c c',
2406 ] 2415 ]
2407 }], 2416 }],
2408 ['enable_autofill_dialog!=1 or OS=="android" or OS=="ios"', { 2417 ['enable_autofill_dialog!=1 or OS=="android" or OS=="ios"', {
2409 'dependencies!': [ 2418 'dependencies!': [
2410 '../third_party/libaddressinput/libaddressinput.gyp:libaddressinput' , 2419 '../third_party/libaddressinput/libaddressinput.gyp:libaddressinput' ,
2411 ], 2420 ],
2412 }], 2421 }],
2413 ['use_ozone==1', {
2414 'sources!': [
2415 # crbug.com/362698
2416 'browser/chromeos/input_method/input_method_engine_browsertests.cc',
2417 'browser/extensions/api/input_ime/input_ime_apitest_chromeos.cc',
2418 ],
2419 }],
2420 ['remoting==1', { 2422 ['remoting==1', {
2421 'sources': [ '<@(chrome_browser_tests_remoting_sources)' ], 2423 'sources': [ '<@(chrome_browser_tests_remoting_sources)' ],
2422 'dependencies': [ 2424 'dependencies': [
2423 '../remoting/remoting.gyp:remoting_webapp', 2425 '../remoting/remoting.gyp:remoting_webapp',
2424 ] 2426 ]
2425 }], 2427 }],
2426 ['use_x11==1', { 2428 ['use_x11==1', {
2427 'dependencies': [ 2429 'dependencies': [
2428 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', 2430 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
2429 ], 2431 ],
(...skipping 743 matching lines...) Expand 10 before | Expand all | Expand 10 after
3173 ['enable_webrtc==1', { 3175 ['enable_webrtc==1', {
3174 'dependencies': [ 3176 'dependencies': [
3175 '../third_party/libjingle/libjingle.gyp:libjingle_webrtc' 3177 '../third_party/libjingle/libjingle.gyp:libjingle_webrtc'
3176 ] 3178 ]
3177 }], 3179 }],
3178 ], 3180 ],
3179 }] 3181 }]
3180 }], 3182 }],
3181 ], # 'conditions' 3183 ], # 'conditions'
3182 } 3184 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | chrome/chrome_tests_unit.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698