Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1003853004: MacViews: Gets wrench menu working (Closed)

Created:
5 years, 9 months ago by Andre
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@grd
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Gets wrench menu working WrenchMenuModel was set up differently between Mac and Views at compile time. This change unifies the model so that the wrench menu can work with MacViews. Use ButtonMenuItemModel as submodels for Cut/Copy/Paste and Zoom/Fullscreen menu buttons. Update Views menu to work with this model change. BUG=425229 Committed: https://crrev.com/d09957e872c13135f85b429ea6a88f6f33e384d4 Cr-Commit-Position: refs/heads/master@{#321016}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -61 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 3 chunks +9 lines, -28 lines 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_menu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_menu.cc View 1 14 chunks +33 lines, -27 lines 0 comments Download
M ui/base/models/button_menu_item_model.h View 1 4 chunks +13 lines, -2 lines 0 comments Download
M ui/base/models/button_menu_item_model.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_model_adapter.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Andre
sky@ PTAL.
5 years, 9 months ago (2015-03-17 19:33:07 UTC) #2
sky
LGTM
5 years, 9 months ago (2015-03-17 23:04:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003853004/20001
5 years, 9 months ago (2015-03-17 23:13:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 23:58:37 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 23:59:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d09957e872c13135f85b429ea6a88f6f33e384d4
Cr-Commit-Position: refs/heads/master@{#321016}

Powered by Google App Engine
This is Rietveld 408576698