Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1003853003: Fix installation of libgl1-mesa-dev and mesa-common-dev in install-build-deps.sh (Closed)

Created:
5 years, 9 months ago by vabr (Chromium)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix installation of libgl1-mesa-dev and mesa-common-dev in install-build-deps.sh On a fresh install of Ubuntu Trusty + Cinnamon, install-build-deps.sh failed, because: * it was looking for libgl1-mesa-dev * Cinnamon forced libgl1-mesa-dev-lts-utopic to be installed * there cannot be two versions of libgl1-mesa-dev* installed This CL adds libgl1-mesa-dev and mesa-common-dev to the group of packages, for which the correct "mesa_variant" suffix is guessed. It also adds "-lts-utopic" to the list of explored suffixes. BUG=466787 Committed: https://crrev.com/f1e8b17f4827ad6030c19f71ebf8e34c91248e2b Cr-Commit-Position: refs/heads/master@{#320889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M build/install-build-deps.sh View 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vabr (Chromium)
Hi torne@, You reviewed similar changes in the past. How does this look to you? ...
5 years, 9 months ago (2015-03-12 21:26:06 UTC) #2
Torne
lgtm
5 years, 9 months ago (2015-03-14 22:35:23 UTC) #3
vabr (Chromium)
Thanks, torne@! Jochen, Could you please rubber-stampt this? Cheers, Vaclav
5 years, 9 months ago (2015-03-16 09:06:57 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-17 10:26:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003853003/1
5 years, 9 months ago (2015-03-17 10:32:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 10:56:43 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 10:57:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1e8b17f4827ad6030c19f71ebf8e34c91248e2b
Cr-Commit-Position: refs/heads/master@{#320889}

Powered by Google App Engine
This is Rietveld 408576698